Initial rough cut at nsmgr command #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depends on networkservicemesh/sdk#170 and will not build without it. Signed-off-by: Ed Warnicke <hagbard@gmail.com>
haiodo
reviewed
Apr 6, 2020
|
|
||
| var envCmd = &cobra.Command{ | ||
| Use: "env", | ||
| Short: "Dumps env for current forwarder settings suitable for evaling", |
There was a problem hiding this comment.
May be we could move this into some kind of constants or messages?
There was a problem hiding this comment.
Could you say more ... I don't quite follow.
| var rootCmd = &cobra.Command{ | ||
| Use: "forwarder", | ||
| Short: "Provides xconnect network service", | ||
| Long: `Provides xconnect network service. Supported mechanisms: |
There was a problem hiding this comment.
Should we obtain a list of supported mechanisms automatically?
There was a problem hiding this comment.
Hmm... you mean introspect somehow to construct the usage?
There was a problem hiding this comment.
Yes, we potentially could extract this info from endpoint, but not sure it will
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on networkservicemesh/sdk#170
and will not build without it.
Signed-off-by: Ed Warnicke hagbard@gmail.com