fix: docker-push job fails and sdk version is not used in case of update from sdk #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le to use sdk-version Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
haiodo
approved these changes
Nov 10, 2020
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Nov 10, 2020
…template@master networkservicemesh/cmd-template#38 networkservicemesh/cmd-template PR link: networkservicemesh/cmd-template#38 networkservicemesh/cmd-template commit message: commit 1d7dbc2a6e061522571c2d3cf720aab3cc5bf4ed Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Tue Nov 10 14:06:21 2020 +0700 fix: docker-push may fail && update-integration-k8s-kind should be able to use sdk-version (#38) Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Nov 10, 2020
…template@master networkservicemesh/cmd-template#38 networkservicemesh/cmd-template PR link: networkservicemesh/cmd-template#38 networkservicemesh/cmd-template commit message: commit 1d7dbc2a6e061522571c2d3cf720aab3cc5bf4ed Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Tue Nov 10 14:06:21 2020 +0700 fix: docker-push may fail && update-integration-k8s-kind should be able to use sdk-version (#38) Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-sriov
that referenced
this pull request
Nov 10, 2020
…template@master networkservicemesh/cmd-template#38 networkservicemesh/cmd-template PR link: networkservicemesh/cmd-template#38 networkservicemesh/cmd-template commit message: commit 1d7dbc2a6e061522571c2d3cf720aab3cc5bf4ed Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Tue Nov 10 14:06:21 2020 +0700 fix: docker-push may fail && update-integration-k8s-kind should be able to use sdk-version (#38) Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc
that referenced
this pull request
Nov 10, 2020
…template@master networkservicemesh/cmd-template#38 networkservicemesh/cmd-template PR link: networkservicemesh/cmd-template#38 networkservicemesh/cmd-template commit message: commit 1d7dbc2a6e061522571c2d3cf720aab3cc5bf4ed Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Tue Nov 10 14:06:21 2020 +0700 fix: docker-push may fail && update-integration-k8s-kind should be able to use sdk-version (#38) Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder
that referenced
this pull request
Nov 10, 2020
…template@master networkservicemesh/cmd-template#38 networkservicemesh/cmd-template PR link: networkservicemesh/cmd-template#38 networkservicemesh/cmd-template commit message: commit 1d7dbc2a6e061522571c2d3cf720aab3cc5bf4ed Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Tue Nov 10 14:06:21 2020 +0700 fix: docker-push may fail && update-integration-k8s-kind should be able to use sdk-version (#38) Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Nov 10, 2020
…template@master networkservicemesh/cmd-template#38 networkservicemesh/cmd-template PR link: networkservicemesh/cmd-template#38 networkservicemesh/cmd-template commit message: commit 1d7dbc2a6e061522571c2d3cf720aab3cc5bf4ed Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Tue Nov 10 14:06:21 2020 +0700 fix: docker-push may fail && update-integration-k8s-kind should be able to use sdk-version (#38) Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-exclude-prefixes-k8s
that referenced
this pull request
Nov 10, 2020
…template@master networkservicemesh/cmd-template#38 networkservicemesh/cmd-template PR link: networkservicemesh/cmd-template#38 networkservicemesh/cmd-template commit message: commit 1d7dbc2a6e061522571c2d3cf720aab3cc5bf4ed Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Tue Nov 10 14:06:21 2020 +0700 fix: docker-push may fail && update-integration-k8s-kind should be able to use sdk-version (#38) Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vppagent
that referenced
this pull request
Nov 10, 2020
…template@master networkservicemesh/cmd-template#38 networkservicemesh/cmd-template PR link: networkservicemesh/cmd-template#38 networkservicemesh/cmd-template commit message: commit 1d7dbc2a6e061522571c2d3cf720aab3cc5bf4ed Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Tue Nov 10 14:06:21 2020 +0700 fix: docker-push may fail && update-integration-k8s-kind should be able to use sdk-version (#38) Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 10, 2020
Closed
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: denis-tingajkin denis.tingajkin@xored.com