[sdk-vpp#314] Update tests to new VPP forwarder #2413
Conversation
Bolodya1997
force-pushed
the
sdk-vpp#314/update-tests
branch
from
8838e72 to
c8165a8
Compare
examples/basic/README.md
Outdated
| - name: forwarder-vpp | ||
| env: | ||
| - name: NSM_SRIOV_CONFIG_FILE | ||
| value: /dev/null |
There was a problem hiding this comment.
Question... why does this have to be set... if you don't configure NSM_SRIOV ... shouldn't it just not be used?
There was a problem hiding this comment.
You are totally right, fixed cmd-forwarder-vpp just not to use SR-IOV if there is no config - networkservicemesh/cmd-forwarder-vpp#343.
Bolodya1997
force-pushed
the
sdk-vpp#314/update-tests
branch
from
c8165a8 to
00b824b
Compare
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Bolodya1997
force-pushed
the
sdk-vpp#314/update-tests
branch
from
00b824b to
7d4149b
Compare
Bolodya1997
requested review from
denis-tingaikin,
glazychev-art and
Mixaster995
There was a problem hiding this comment.
LGTM
@edwarnicke Do you have any additional comments on this?
| @@ -1,42 +0,0 @@ | |||
| ## Requires | |||
There was a problem hiding this comment.
Can we just disable this example?
There was a problem hiding this comment.
@pperiyasamy How are you on getting the cmd-forwarder-ovs into a place we could put it in the examples?
There was a problem hiding this comment.
@denis-tingaikin One option is to simply use the cmd-forwarder-vpp and not provide it a SRIOV config (and thus it won't handle SRIOV case).
There was a problem hiding this comment.
@edwarnicke The cmd-forwarder-ovs runs only in kernel datapath if no SRIOV config provided. when sriov config exists, then it supports both kernel and smart nic, the connection type would be chosen based on client service request URL.
…ployments-k8s@main PR link: networkservicemesh/deployments-k8s#2413 Commit: e5f2ac6 Author: Network Service Mesh Bot Date: 2021-09-27 05:44:34 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/de… Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Description
Use VPP Forwarder with SR-IOV capabilities instead of SR-IOV Forwarder in all tests.
Issue link
Needed for networkservicemesh/sdk-vpp#314.
How Has This Been Tested?
Types of changes