Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add policy based routing test #4273

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Jan 18, 2022

Issue: networkservicemesh/api#119

Signed-off-by: Artem Glazychev artem.glazychev@xored.com

@glazychev-art
Copy link
Contributor Author

@edwarnicke @zolug @tedlean
Could you please take a look at this example? It is related to Policy Based Routing issue.
Is this what we want to see?

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@glazychev-art glazychev-art changed the title [WIP] Add policy based routing test Add policy based routing test Jan 25, 2022
@glazychev-art glazychev-art marked this pull request as ready for review January 25, 2022 07:18
data:
config.yaml: |
- from: 172.16.2.201/24
proto: 6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field is super hard to understand. I think we should consider improving clarity.

- proto: 17
port: 6666
- from: 2004::3/120
proto: 17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field is super hard to understand. I think we should consider improving clarity.

routes:
- prefix: 172.16.3.0/24
nexthop: 172.16.2.200
- proto: 17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field is super hard to understand. I think we should consider improving clarity.

Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glazychev-art Is it possible to replace proto: ${number} to something human readable?

@denis-tingaikin
Copy link
Member

OK, I see that protocol numbers are known https://en.wikipedia.org/wiki/List_of_IP_protocol_numbers

So merging.

@edwarnicke Let us know if you will have any questions or comments on this example.

@denis-tingaikin denis-tingaikin merged commit 91fa5d5 into networkservicemesh:main Jan 25, 2022
nsmbot pushed a commit to networkservicemesh/integration-tests that referenced this pull request Jan 25, 2022
…ployments-k8s@main

PR link: networkservicemesh/deployments-k8s#4273

Commit: 4b340c5
Author: Network Service Mesh Bot
Date: 2022-01-25 01:05:35 -0600
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/de…
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants