Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ovs examples #5493

Merged
merged 1 commit into from
May 3, 2022
Merged

Conversation

ljkiraly
Copy link
Contributor

Remove cpu resource limit from forwarder app configuration
Re-add ovs-forwarder tests to remote vlan examples

Signed-off-by: Laszlo Kiraly laszlo.kiraly@est.tech

Using debug PRs I was able to find the reason why cmd-forwarder-ovs does not started during integration test run in GihHub. The kubectl describe pod command output revealed why the scheduling failed:


Warning  FailedScheduling  23s (x4 over 4m)  default-scheduler  0/3 nodes are available: 1 Insufficient cpu, 1 node(s) didn't match Pod's node affinity/selector, 1 node(s) had taint {node-role.kubernetes.io/master: }, that the pod didn't tolerate. TestRunRvlanSuiteSingle/Rvlanovs=stdout

The kind worker nodes can allocate 2 CPUs:

time=2022-04-13T14:14:25Z level=info msg=kubectl get nodes -o jsonpath='{range .items[*]}{.metadata.name}{": "}{.status.allocatable}{"\n"}{end}' --selector='!node-role.kubernetes.io/master' TestRunRvlanSuiteSingle/Rvlanovs=stdin
918
time=2022-04-13T14:14:25Z level=info msg=kind-worker: {"cpu":"2","ephemeral-storage":"87218124Ki","hugepages-1Gi":"0","hugepages-2Mi":"0","memory":"7113132Ki","pods":"110"}
919
kind-worker2: {"cpu":"2","ephemeral-storage":"87218124Ki","hugepages-1Gi":"0","hugepages-2Mi":"0","memory":"7113132Ki","pods":"110"} TestRunRvlanSuiteSingle/Rvlanovs=stdout

I did not find any system requirement in Open vSwitch documentation regarding the CPU so I removed this resource limit. The kind jobs ran successfully after this change:
https://github.com/networkservicemesh/integration-k8s-kind/actions/runs/2162217426

@ljkiraly ljkiraly marked this pull request as ready for review April 14, 2022 11:51
Remove cpu resource limit from forwarder app configuration
Re-add ovs-forwarder tests to remote vlan examples

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
@ljkiraly ljkiraly force-pushed the fix-ovs-resource-limits branch from 486b068 to 9cc51ad Compare April 25, 2022 12:47
@edwarnicke edwarnicke merged commit b38482c into networkservicemesh:main May 3, 2022
nsmbot pushed a commit to networkservicemesh/integration-tests that referenced this pull request May 3, 2022
…ployments-k8s@main

PR link: networkservicemesh/deployments-k8s#5493

Commit: e0c707a
Author: Network Service Mesh Bot
Date: 2022-04-30 13:21:54 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/de…
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants