Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dual stack examples #5569

Merged
merged 1 commit into from
May 5, 2022
Merged

Conversation

ljkiraly
Copy link
Contributor

@ljkiraly ljkiraly commented Apr 26, 2022

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
@ljkiraly ljkiraly marked this pull request as ready for review May 3, 2022 16:33
@ljkiraly
Copy link
Contributor Author

ljkiraly commented May 3, 2022

@edwarnicke Note, that the new tests takes ~2 min to run, which might cause timeout. Not yet increased test timeout in integration-k8s-kind.

@edwarnicke
Copy link
Member

@ljkiraly Any idea why its takin so long?

@ljkiraly
Copy link
Contributor Author

ljkiraly commented May 4, 2022

@edwarnicke Not an extreme increase, just take the same amount of time as IPv6 TCs, the ping4 is an extra.

@edwarnicke
Copy link
Member

@ljkiralyIs this ready to merge?

@ljkiraly
Copy link
Contributor Author

ljkiraly commented May 5, 2022

@edwarnicke Yes, ready from my side.

@edwarnicke edwarnicke merged commit 460a0c7 into networkservicemesh:main May 5, 2022
nsmbot pushed a commit to networkservicemesh/integration-tests that referenced this pull request May 5, 2022
…ployments-k8s@main

PR link: networkservicemesh/deployments-k8s#5569

Commit: db1fe9c
Author: Network Service Mesh Bot
Date: 2022-05-05 09:16:50 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/de…
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants