Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from update/networkservicemesh/cmd-forwarder-vpp #7674

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

nsmbot
Copy link
Contributor

@nsmbot nsmbot commented Oct 25, 2022

Update go.mod and go.sum to latest version from networkservicemesh/cmd-forwarder-vpp@main
PR link: networkservicemesh/cmd-forwarder-vpp#739
Commit: a2c0b6d
Author: Ed Warnicke
Date: 2022-10-25 02:59:01 -0500
Message:

  • Final fix to disable IPv6 RA when NSM_TUNNEL_IP is IPv6 (# 739)
    VPP, being a router, presumes that any IPv6 enabled interface should,
    by default, be sending IPv6 Router Announcements (RAs).
    In our case, this is an incorrect behavior.
    In the past we had attempted using:
    'ip6 nd host-%s ra-cease'
    this did not work as expected for two reasons:
  1. It was done before assigning an IPv6 address to the interface.
    Because of this the interface does not yet have IPv6 enabled,
    and therefore the 'ip6 nd host-%s ra-cease' has no effect.
  2. 'ip6 nd host-%s ra-cease' only precluded repetition of RAs
    after the interface is up. Initial RAs are still sent.
    This can be fixed by adding 'ra-suppress'
    So in short, we use:
    'enable ip6 interface host-%s'
    'ip6 nd host-%s ra-cease ra-suppress'
    which disables any sending of RAs from the interface prior to it
    being 'upped'.
    This has been tested using tcpdump. Tcpdump was used in the uncorrected
    case to ensure it correctly detects RAs being sent out (it does)
    Tcpdump was used to determine that with:
    'enable ip6 interface host-%s'
    'ip6 nd host-%s ra-cease'
    the initial RA is sent, but no subsequent RAs.
    The actual fix was tested with tcpdump to ensure that
    'enable ip6 interface host-%s'
    'ip6 nd host-%s ra-cease ra-suppress'
    results in no RAs being sent.
    Finally, tcpdump was used to ensure that with the code being submitted
    was used, not RAs were sent out.
    Signed-off-by: Ed Warnicke hagbard@gmail.com

…d-forwarder-vpp@main

PR link: networkservicemesh/cmd-forwarder-vpp#739

Commit: a2c0b6d
Author: Ed Warnicke
Date: 2022-10-25 02:59:01 -0500
Message:
  - Final fix to disable IPv6 RA when NSM_TUNNEL_IP is IPv6 (#739)
VPP, being a router, presumes that any IPv6 enabled interface should,
by default, be sending IPv6 Router Announcements (RAs).

In our case, this is an incorrect behavior.

In the past we had attempted using:

'ip6 nd host-%s ra-cease'

this did not work as expected for two reasons:

1.  It was done before assigning an IPv6 address to the interface.
    Because of this the interface does not yet have IPv6 enabled,
    and therefore the 'ip6 nd host-%s ra-cease' has no effect.
2.  'ip6 nd host-%s ra-cease' only precluded repetition of RAs
    after the interface is up.  Initial RAs are still sent.
    This can be fixed by adding 'ra-suppress'

So in short, we use:
'enable ip6 interface host-%s'
'ip6 nd host-%s ra-cease ra-suppress'

which disables any sending of RAs from the interface prior to it
being 'upped'.

This has been tested using tcpdump. Tcpdump was used in the uncorrected
case to ensure it correctly detects RAs being sent out (it does)
Tcpdump was used to determine that with:

'enable ip6 interface host-%s'
'ip6 nd host-%s ra-cease'

the initial RA is sent, but no subsequent RAs.

The actual fix was tested with tcpdump to ensure that

'enable ip6 interface host-%s'
'ip6 nd host-%s ra-cease ra-suppress'

results in *no* RAs being sent.

Finally, tcpdump was used to ensure that with the code being submitted
was used, not RAs were sent out.

Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@github-actions github-actions bot merged commit c2118bb into main Oct 25, 2022
nsmbot pushed a commit to networkservicemesh/integration-tests that referenced this pull request Oct 25, 2022
…ployments-k8s@main

PR link: networkservicemesh/deployments-k8s#7674

Commit: 16d84a9
Author: Network Service Mesh Bot
Date: 2022-10-24 07:33:54 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/de…
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant