Skip to content

Commit

Permalink
Merge pull request #39 from Tantalor93/fixh
Browse files Browse the repository at this point in the history
remove unused healthcheck metrics
denis-tingaikin authored Oct 15, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
2 parents 6d49839 + 2e9b0f4 commit 519fee1
Showing 2 changed files with 0 additions and 15 deletions.
3 changes: 0 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -36,9 +36,6 @@ If monitoring is enabled (via the *prometheus* plugin) then the following metric
* `coredns_fanout_request_duration_seconds{to}` - duration per upstream interaction.
* `coredns_fanout_request_count_total{to}` - query count per upstream.
* `coredns_fanout_response_rcode_count_total{to, rcode}` - count of RCODEs per upstream.
* `coredns_fanout_healthcheck_failure_count_total{to}` - number of failed health checks per upstream.
* `coredns_fanout_healthcheck_broken_count_total{}` - counter of when all upstreams are unhealthy,
and we are randomly (this always uses the `random` policy) spraying to an upstream.

Where `to` is one of the upstream servers (**TO** from the config), `rcode` is the returned RCODE
from the upstream.
12 changes: 0 additions & 12 deletions metrics.go
Original file line number Diff line number Diff line change
@@ -43,16 +43,4 @@ var (
Buckets: plugin.TimeBuckets,
Help: "Histogram of the time each request took.",
}, []string{"to"})
HealthcheckFailureCount = promauto.NewCounterVec(prometheus.CounterOpts{
Namespace: plugin.Namespace,
Subsystem: "fanout",
Name: "healthcheck_failure_count_total",
Help: "Counter of the number of failed healthchecks.",
}, []string{"to"})
HealthcheckBrokenCount = promauto.NewCounter(prometheus.CounterOpts{
Namespace: plugin.Namespace,
Subsystem: "fanout",
Name: "healthcheck_broken_count_total",
Help: "Counter of the number of complete failures of the healthchecks.",
})
)

0 comments on commit 519fee1

Please sign in to comment.