-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin fanout: update coredns deps #25
Conversation
Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
怎么还没合并? |
Cloning into 'coredns'... github.com/networkservicemesh/fanout../../pkg/mod/github.com/networkservicemesh/fanout@v0.0.0-20200803070946-b663b8bd9437/setup.go:60:3: undefined: metrics.MustRegister |
@haiodo @denis-tingajkin |
@snakwu Ah, I got it, you are using |
@snakwu Indeed they have updated the metrics stuff but they did not provide a new version with this change. Currently, the new version is 1.7 that is working fine with fanout plugin. Can you just checkout on the tag 1.7? |
cd $COREDNS_FOLDER
git checkout v1.7.0
make |
snakwu@hassio-server: github.com/networkservicemesh/fanout../../pkg/mod/github.com/networkservicemesh/fanout@v0.0.0-20200803070946-b663b8bd9437/setup.go:60:3: undefined: metrics.MustRegister |
@snakwu
|
snakwu@hassio-server: |
@snakwu Probably you need to upgrade your |
为什么会这样,以前一直是直接make就可以的了,什么时候修复一下 |
@snakwu |
snakwu@hassio-server:
github.com/networkservicemesh/fanout../../pkg/mod/github.com/networkservicemesh/fanout@v0.0.0-20200803070946-b663b8bd9437/setup.go:60:3: undefined: metrics.MustRegister |
切换了v1.70分支,仍然不行 |
@snakwu Can not reproduce Here is my log on the branch v1.7.0
|
@snakwu can you attach your
|
go version go1.13.4 linux/amd64������ |
What is the latest commit hash you see in |
commit 975305732e72246890a10fb2cddf0d2ce32c916c (HEAD -> v1.70, origin/master, origin/HEAD, master)
commit f23171af5f3f6432c249e26265ec6540f6c1b46b
commit ec906fe37f652924c056b967de38b3c5d926ee92
commit 118b4fa4c910531fc0d53c14df93db1b521c9fb0
commit 05a0eff29309d2e2037c171486d50f8820e436d0
commit 679e8dc8343f2c5fc63eb4096e6f3102286bad58
commit 717851e1432a936e1e058e1bd73e60e6e32037b0
|
@snakwu As I can see your last commit is not the last commit of v1.7.0
|
为什么会这样呢,我以前的做法是直接git clone coerdns master 然后修改plugin.cfg,再make就ok了,现在变得这么复杂了? |
希望能修复下这个问题 |
It is not a safe approach. So we'll update coredns version and apply fixes when coredns has released new version :) You can simply change your approach to |
我应该怎么样来git clone v1.7.0 |
@snakwu
|
snakwu@hassio-server: |
@snakwu I think you need to figure out how you can fetch tags from the repository. |
不行,仍然无法编译 |
ok,已经成功切换v1.7.0,然后成功构建了!但我还是很希望像以前那样,直接可以在master下构建 |
@snakwu |
ok,thx |
可否让fanout支持doh??谢谢 |
@denis-tingajkin coerdns v1.7.1 is out! |
Signed-off-by: denis-tingajkin denis.tingajkin@xored.com
Motivation
This PR updates dependency on coredns and should fix #24