Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add span per connection attempt #36

Merged
merged 2 commits into from
Jul 17, 2021

Conversation

Tantalor93
Copy link

Signed-off-by: Ondrej Benkovsky ondrej.benkovsky@wandera.com

Hello, I would like to improve the observability of fanout plugin by adding opentracing spans per upstream connection attempt similarly as CoreDNS forward plugin does. You can then better see the performance of each DNS upstream nameserver

Example how it looks like:
Let's have a CoreDNS instance running with Corefile

.:53 {
    fanout . 8.8.8.8 9.9.9.9
    trace zipkin 127.0.0.1:9411 {
              service dns-service
    }
}

and locally running Zipkin in docker

docker run -d -p 9411:9411 openzipkin/zipkin

when you do the DNS request through this CoreDNS instance

dig @127.0.0.1 example.com

it will create a trace such as this (screen from Zipkin UI)

image

Signed-off-by: Ondrej Benkovsky <ondrej.benkovsky@wandera.com>
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Tantalor93 for the patch!
It makes sense.
Please take a at my comment.

Signed-off-by: Ondrej Benkovsky <ondrej.benkovsky@wandera.com>
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@denis-tingaikin denis-tingaikin merged commit 1892892 into networkservicemesh:master Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants