Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ondrej Benkovsky ondrej.benkovsky@wandera.com
Hello, I would like to improve the observability of fanout plugin by adding opentracing spans per upstream connection attempt similarly as CoreDNS forward plugin does. You can then better see the performance of each DNS upstream nameserver
Example how it looks like:
Let's have a CoreDNS instance running with Corefile
and locally running Zipkin in docker
when you do the DNS request through this CoreDNS instance
it will create a trace such as this (screen from Zipkin UI)