Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry to generated bash scripts #43

Merged
merged 13 commits into from
Sep 22, 2023

Conversation

d-uzlov
Copy link
Contributor

@d-uzlov d-uzlov commented Aug 11, 2023

Fix bash script generation for multi-line commands.
Add retry function into bash scripts when --retry argument is specified.
Run all setup and test commands through retry function.
Fix cleanup.

Issue:

d-uzlov added 4 commits July 31, 2023 15:08
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
@d-uzlov
Copy link
Contributor Author

d-uzlov commented Aug 11, 2023

It seems like this PR broke test name matching:

Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add an option --retry and use these changes only and only if the option has presented on generating?

Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
@d-uzlov d-uzlov requested a review from NikitaSkrynnik August 24, 2023 06:21
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
@denis-tingaikin denis-tingaikin merged commit f5fd88d into networkservicemesh:main Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants