CI initial commit #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
| name: ci | ||
| on: pull_request | ||
| jobs: | ||
| yamllint: |
There was a problem hiding this comment.
yamllint job can be simplified https://github.com/networkservicemesh/cmd-template/blob/master/.github/workflows/ci.yaml#L9
| - uses: actions/checkout@v2 | ||
| - name: shellcheck | ||
| uses: fkautz/shell-linter@v1.0.1 | ||
| golangci-lint: |
There was a problem hiding this comment.
golangci-lint job can be simplified https://github.com/networkservicemesh/cmd-template/blob/master/.github/workflows/ci.yaml#L42
.github/workflows/ci.yaml
Outdated
| echo "Please use errors.Errorf (or errors.New or errors.Wrap or errors.Wrapf) as appropriate rather than fmt.Errorf" | ||
| exit 1 | ||
| fi | ||
| restrictNSMDeps: |
There was a problem hiding this comment.
I think this can be removed.
.github/workflows/ci.yaml
Outdated
| run: | | ||
| git diff -- '*.pb.go' || ( echo "Rerun go generate ./... locally and resubmit" && false ) | ||
| git diff -- '*.gen.go' || ( echo "Rerun go generate ./... locally and resubmit" && false ) | ||
| captureRunEnv: |
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
denis-tingaikin
approved these changes
Oct 1, 2020
nsmbot
pushed a commit
that referenced
this pull request
Apr 10, 2021
…tegration-k8s-kind@master networkservicemesh/integration-k8s-kind# networkservicemesh/integration-k8s-kind PR link: https://github.com/networkservicemesh/integration-k8s-kind/pull/ networkservicemesh/integration-k8s-kind commit message: commit e4821984b055475fc475073437e85978987515b2 Author: Ed Warnicke <hagbard@gmail.com> Date: Sat Apr 10 13:06:35 2021 -0500 Merge pull request #152 from denis-tingaikin/fix-automerge-job-is-not-working-pt2 fix: automerge job can not do merge #2 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
that referenced
this pull request
Apr 10, 2021
…tegration-k8s-kind@master networkservicemesh/integration-k8s-kind# networkservicemesh/integration-k8s-kind PR link: https://github.com/networkservicemesh/integration-k8s-kind/pull/ networkservicemesh/integration-k8s-kind commit message: commit e4821984b055475fc475073437e85978987515b2 Merge: 67d071b ef6a55e Author: Ed Warnicke <hagbard@gmail.com> Date: Sat Apr 10 13:06:35 2021 -0500 Merge pull request #152 from denis-tingaikin/fix-automerge-job-is-not-working-pt2 fix: automerge job can not do merge #2 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.