Improved describe method #1103
Merged
Improved describe method #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-tingaikin
approved these changes
Nov 22, 2021
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
Mixaster995
force-pushed
the
enhancement/improve-describe
branch
from
b4cbdc5 to
20b5fb9
Compare
extensions/logs/logs.go
Outdated
| } | ||
| } | ||
|
|
||
| func getNamespaces(nsList *corev1.NamespaceList) []string { |
There was a problem hiding this comment.
Suggested change
| func getNamespaces(nsList *corev1.NamespaceList) []string { | |
| func filterNamespaces(nsList *corev1.NamespaceList) []string { |
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
nsmbot
pushed a commit
to networkservicemesh/integration-k8s-kind
that referenced
this pull request
Dec 2, 2021
…tegration-tests@main PR link: networkservicemesh/integration-tests#1103 Commit: d8b8af7 Author: Denis Tingaikin Date: 2021-12-03 02:09:01 +0300 Message: - Merge pull request #1103 from Mixaster995/enhancement/improve-describe Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
that referenced
this pull request
Dec 3, 2021
…ployments-k8s@main PR link: https://github.com/networkservicemesh/deployments-k8s/pull/ Commit: d8b8af7 Author: Denis Tingaikin Date: 2021-12-03 02:09:01 +0300 Message: - Merge pull request #1103 from Mixaster995/enhancement/improve-describe Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
that referenced
this pull request
Dec 3, 2021
…ployments-k8s@main PR link: networkservicemesh/deployments-k8s#3974 Commit: d8b8af7 Author: Denis Tingaikin Date: 2021-12-03 02:09:01 +0300 Message: - Merge pull request #1103 from Mixaster995/enhancement/improve-describe Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
that referenced
this pull request
Dec 3, 2021
…ployments-k8s@main PR link: networkservicemesh/deployments-k8s#3976 Commit: d8b8af7 Author: Denis Tingaikin Date: 2021-12-03 02:09:01 +0300 Message: - Merge pull request #1103 from Mixaster995/enhancement/improve-describe Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
that referenced
this pull request
Dec 3, 2021
…ployments-k8s@main PR link: https://github.com/networkservicemesh/deployments-k8s/pull/ Commit: d8b8af7 Author: Denis Tingaikin Date: 2021-12-03 02:09:01 +0300 Message: - Merge pull request #1103 from Mixaster995/enhancement/improve-describe Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
that referenced
this pull request
Dec 3, 2021
…ployments-k8s@main PR link: https://github.com/networkservicemesh/deployments-k8s/pull/ Commit: d8b8af7 Author: Denis Tingaikin Date: 2021-12-03 02:09:01 +0300 Message: - Merge pull request #1103 from Mixaster995/enhancement/improve-describe Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mikhail Avramenko avramenkomihail15@gmail.com