fix: chain element 'createpod' doesn't work correctly for interdomain scenarios #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. resolve issue networkservicemesh#165 Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
resolve-issue-165
branch
2 times, most recently
from
ed7e1d6 to
5e39a48
Compare
denis-tingaikin
force-pushed
the
resolve-issue-165
branch
from
5e39a48 to
4eded7b
Compare
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-sriov
that referenced
this pull request
May 12, 2022
…k-k8s@main PR link: networkservicemesh/sdk-k8s#356 Commit: cb9e385 Author: Ed Warnicke Date: 2022-05-12 17:21:21 -0500 Message: - Merge pull request #356 from denis-tingaikin/resolve-issue-165 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-exclude-prefixes-k8s
that referenced
this pull request
May 12, 2022
…k-k8s@main PR link: networkservicemesh/sdk-k8s#356 Commit: cb9e385 Author: Ed Warnicke Date: 2022-05-12 17:21:21 -0500 Message: - Merge pull request #356 from denis-tingaikin/resolve-issue-165 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-k8s
that referenced
this pull request
May 12, 2022
…k-k8s@main PR link: networkservicemesh/sdk-k8s#356 Commit: cb9e385 Author: Ed Warnicke Date: 2022-05-12 17:21:21 -0500 Message: - Merge pull request #356 from denis-tingaikin/resolve-issue-165 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
May 12, 2022
…k-k8s@main PR link: networkservicemesh/sdk-k8s#356 Commit: cb9e385 Author: Ed Warnicke Date: 2022-05-12 17:21:21 -0500 Message: - Merge pull request #356 from denis-tingaikin/resolve-issue-165 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-supplier-k8s
that referenced
this pull request
May 12, 2022
…k-k8s@main PR link: networkservicemesh/sdk-k8s#356 Commit: cb9e385 Author: Ed Warnicke Date: 2022-05-12 17:21:21 -0500 Message: - Merge pull request #356 from denis-tingaikin/resolve-issue-165 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced May 12, 2022
Merged
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-supplier-k8s
that referenced
this pull request
May 13, 2022
…k-k8s@main PR link: networkservicemesh/sdk-k8s#356 Commit: cb9e385 Author: Ed Warnicke Date: 2022-05-12 17:21:21 -0500 Message: - Merge pull request #356 from denis-tingaikin/resolve-issue-165 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
edwarnicke
pushed a commit
to networkservicemesh/cmd-nse-supplier-k8s
that referenced
this pull request
May 13, 2022
…k-k8s@main PR link: networkservicemesh/sdk-k8s#356 Commit: cb9e385 Author: Ed Warnicke Date: 2022-05-12 17:21:21 -0500 Message: - Merge pull request #356 from denis-tingaikin/resolve-issue-165 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Signed-off-by: Ed Warnicke <hagbard@gmail.com>
denis-tingaikin
pushed a commit
to networkservicemesh/cmd-nse-supplier-k8s
that referenced
this pull request
May 13, 2022
…k-k8s@main PR link: networkservicemesh/sdk-k8s#356 Commit: cb9e385 Author: Ed Warnicke Date: 2022-05-12 17:21:21 -0500 Message: - Merge pull request #356 from denis-tingaikin/resolve-issue-165 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Denis Tingaikin denis.tingajkin@xored.com
Motivation
This PR improves
createpodchain element.The element is still prevent creating more then one pod for scale from zero on the local cluster, but its requires to use the same pod name in the template. (Currently we do that https://github.com/networkservicemesh/deployments-k8s/blob/main/examples/features/scale-from-zero/pod-template.yaml#L5. So nothing is changed for this use-case)
The element is able to create a POD on a different NODE, only and only if
labels.NodeNameis incorrect for the current cluster.Closes createpod doesn't delete dead pods, spawned by the old createpod instance #165
Simplifies overthinking code.
Covers all scenarious by unit testing via fake k8s client.