Rework etcd chain element to distinguish between begin.Unregister() and nse.Unregister() events
#460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following tests failed: |
|
@dualBreath These tests will start working when this PR networkservicemesh/sdk#1542 is merged. |
|
LGTM |
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
denis-tingaikin
approved these changes
Nov 8, 2023
nsmbot
pushed a commit
to networkservicemesh/cmd-exclude-prefixes-k8s
that referenced
this pull request
Nov 8, 2023
…k-k8s@main PR link: networkservicemesh/sdk-k8s#460 Commit: 7331026 Author: Denis Tingaikin Date: 2023-11-08 17:56:15 +0300 Message: - Merge pull request #460 from NikitaSkrynnik/scale Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Nov 8, 2023
…k-k8s@main PR link: networkservicemesh/sdk-k8s#460 Commit: 7331026 Author: Denis Tingaikin Date: 2023-11-08 17:56:15 +0300 Message: - Merge pull request #460 from NikitaSkrynnik/scale Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-k8s
that referenced
this pull request
Nov 8, 2023
…k-k8s@main PR link: networkservicemesh/sdk-k8s#460 Commit: 7331026 Author: Denis Tingaikin Date: 2023-11-08 17:56:15 +0300 Message: - Merge pull request #460 from NikitaSkrynnik/scale Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-ovs
that referenced
this pull request
Nov 8, 2023
…k-k8s@main PR link: networkservicemesh/sdk-k8s#460 Commit: 7331026 Author: Denis Tingaikin Date: 2023-11-08 17:56:15 +0300 Message: - Merge pull request #460 from NikitaSkrynnik/scale Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-supplier-k8s
that referenced
this pull request
Nov 8, 2023
…k-k8s@main PR link: networkservicemesh/sdk-k8s#460 Commit: 7331026 Author: Denis Tingaikin Date: 2023-11-08 17:56:15 +0300 Message: - Merge pull request #460 from NikitaSkrynnik/scale Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 8, 2023
Merged
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-sriov
that referenced
this pull request
Nov 8, 2023
…k-k8s@main PR link: networkservicemesh/sdk-k8s#460 Commit: 7331026 Author: Denis Tingaikin Date: 2023-11-08 17:56:15 +0300 Message: - Merge pull request #460 from NikitaSkrynnik/scale Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 8, 2023
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Nov 8, 2023
…k-k8s@main PR link: networkservicemesh/sdk-k8s#460 Commit: 7331026 Author: Denis Tingaikin Date: 2023-11-08 17:56:15 +0300 Message: - Merge pull request #460 from NikitaSkrynnik/scale Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#456
Description
How we distinguish between events from
beginand NSE:etcdputs NSE version into context on NSE registerexpireuses the version from this context when it callsbegin.Unregister(). (Changes forexpirecan be found here: Extend expireContext inexpirechain element with values from request context sdk#1533)etcdon Unregister gets the version for the context, it know that this Unregister event has been sent frombegin. If context doensn't have the version,etcdjust deletes NSE without version checking.