add xconnectns, l2ovsconnect and mechanism chain elements #1
Conversation
pperiyasamy
force-pushed
the
chain-elements
branch
2 times, most recently
from
a3b4ced to
625b5cf
Compare
|
@pperiyasamy Could you copy ci files from SDK and provide them to this repo sepratly? Currently, this repo has not ci. I think it would be cool to run linters, builds, tests, and so on this PR :) |
|
@pperiyasamy I'd highly recommend starting with robust CI and then moving files in. We tend to turn on a lot of golangci-lint checks for example. Its much much easier to start from there than to try to bring them in later. |
| @@ -0,0 +1,75 @@ | |||
| // Copyright (c) 2021 Nordix Foundation. | |||
There was a problem hiding this comment.
In sdk-vpp I choose to omit the 'common' because, the chain elements were all about vpp.
So rather than pkg/networkservice/common/mechanisms/kernel/client.go I had pkg/networkservice/mechanisms/kernel/client.go etc.
There was a problem hiding this comment.
@edwarnicke done. the kernel mechanism with token id has to be revisited later (would need to realign those chain elements a bit) once resource pool and client pr is checked in.
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
pperiyasamy
force-pushed
the
chain-elements
branch
from
625b5cf to
994e27d
Compare
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
pperiyasamy
force-pushed
the
chain-elements
branch
from
9c2b0c4 to
684aef6
Compare
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
pperiyasamy
force-pushed
the
chain-elements
branch
from
789d687 to
abb55a1
Compare
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
…ements Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
pperiyasamy
force-pushed
the
chain-elements
branch
from
15d560e to
ee291fd
Compare
having l2ovsconnect server chain element after connect server breaks the vWire connection and invokes close handler after connection establishment. Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
.github/workflows/ci.yaml
Outdated
| @@ -18,7 +18,7 @@ jobs: | |||
| runs-on: ${{ matrix.os }} | |||
| strategy: | |||
| matrix: | |||
| os: [ubuntu-latest, macos-latest, windows-latest] | |||
| os: [ubuntu-latest] | |||
There was a problem hiding this comment.
I'd suggest keeping the macos-latest and windows-latest here. Not because your code will run on them (obviously it won't) but because it forces you to proper discipline about applying build tags to mark out code that doesn't run on them. That way if someone tries to pull your code for local development... they don't get weird build errors.
There was a problem hiding this comment.
@edwarnicke I tried to downgrade of nettlink library into v1.1.0 version to make ci to succeed for macOS and windows as well, but Mellanox's sriovnet needs its latest version, because of this ci failing early in lint and ubuntu checks. this was a reason why I made ci to run only ubuntu platform ;) do you've suggestion to fix this ?
There was a problem hiding this comment.
@pperiyasamy Don't fret about the netlink lib. Here's what I've done in sdk-vpp.
In places I am using the netllink lib (or other linux-ism), I just set the proper build tags:
Then for the things that import the thing I marked with // build + linux, I also mark them.
Your issue isn't that you are using a version of netlink that doesn't work on Mac OS (no version of netlink will work on Mac OS). Its that you aren't marking things as only working on linux with build tags.
Does that help?
There was a problem hiding this comment.
thanks @edwarnicke, it helps. done.
pperiyasamy
force-pushed
the
chain-elements
branch
3 times, most recently
from
b422b1a to
8d0b4c9
Compare
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
pperiyasamy
force-pushed
the
chain-elements
branch
from
8d0b4c9 to
8927977
Compare
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
pperiyasamy
force-pushed
the
chain-elements
branch
from
a8ac465 to
a52144b
Compare
this would stabilize vwire connection when connect server's Request fails due to context cancel error. Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
This PR adds the relevant chain elements needed in sdk-ovs for basic l2 connectivity between client and endpoint.
Signed-off-by: Periyasamy Palanisamy periyasamy.palanisamy@est.tech