Use postpone.ContextWithValues() for Close on failure cases #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bolodya1997
reviewed
Aug 31, 2021
| @@ -56,16 +57,21 @@ func (c *kernelClient) Request(ctx context.Context, request *networkservice.Netw | |||
| if err != nil || request.GetConnection().GetNextPathSegment() != nil { | |||
| return conn, err | |||
| } | |||
| postponeCtxFunc := postpone.ContextWithValues(ctx) | |||
There was a problem hiding this comment.
I suppose that it would be better to use the following pattern:
postponeCtxFunc := postpone.ContextWithValues(ctx) // 1. first store ctx
conn, err := next.Request() // 2. after make Request
if err != nil {
...
return nil, err
}
// 3. at this moment we most probably have stored context with timeout enough to make
// a Close, because it was enough for making a RequestThere was a problem hiding this comment.
@Bolodya1997 yes, I see your point, made the changes now.
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
pperiyasamy
force-pushed
the
ctx-postpone
branch
from
1f1a261 to
e032334
Compare
Bolodya1997
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Periyasamy Palanisamy periyasamy.palanisamy@est.tech
Description
Issue link
How Has This Been Tested?
Types of changes