Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vfconfig client chain element #223

Merged
merged 4 commits into from
Aug 30, 2021

Conversation

pperiyasamy
Copy link
Member

this enables facility to store vfinfo (pf, vf interface names, vf num) in resource pool client chain element and this info would get referred in further chain elements.

Signed-off-by: Periyasamy Palanisamy periyasamy.palanisamy@est.tech

@Bolodya1997
Copy link

vfconfig server injects VF config into the Request context, so it is accessible both from the server and from the client chain elements. If you want to create different VF configs for the server chain before connect and for the client chain in the connect, you probably need to add some isClient flag as it is done in metadata:
https://github.com/networkservicemesh/sdk/blob/fe8d8e6e825a3ff8024b8f8726eb028e2385ca1f/pkg/networkservice/utils/metadata/context.go#L49
In such case there is no need to add vfconfig client, you more probably just need to alter vfconfig context methods in the sdk-kernel:
https://github.com/networkservicemesh/sdk-kernel/blob/main/pkg/kernel/networkservice/vfconfig/context.go

So for me this client looks applicable only for the pure client chains (only on NSC), so if you are not planning to use it in there, I don't think that we need these changes.

@pperiyasamy
Copy link
Member Author

pperiyasamy commented Aug 3, 2021

@Bolodya1997 yes, you are correct, both client and server going to consume different vfconfig, so this must be enhanced to have isClient flag to have both server and client vfconfig. I think you meant to change vfconfig/context.go with APIs to something similar to this. Am I correct ?

@pperiyasamy
Copy link
Member Author

This need rebase after this sdk-kernel PR is merged and CI is expected to pass.

@denis-tingaikin
Copy link
Member

@pperiyasamy Could you rebase this PR?

this enables facility to store vfinfo (pf/vf interface name, vf id) in resource pool client chain element and this info might get referred in further chain elements.

Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
@denis-tingaikin
Copy link
Member

@Bolodya1997 Could you also review this?

@denis-tingaikin denis-tingaikin merged commit a20f8ee into networkservicemesh:main Aug 30, 2021
nsmbot pushed a commit to networkservicemesh/cmd-nsc that referenced this pull request Aug 30, 2021
…k-sriov@main

PR link: networkservicemesh/sdk-sriov#223

Commit: a20f8ee
Author: Denis Tingaikin
Date: 2021-08-30 10:54:47 +0300
Message:
  - Merge pull request #223 from Nordix/vfconfig-client
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Aug 30, 2021
…k-sriov@main

PR link: networkservicemesh/sdk-sriov#223

Commit: a20f8ee
Author: Denis Tingaikin
Date: 2021-08-30 10:54:47 +0300
Message:
  - Merge pull request #223 from Nordix/vfconfig-client
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-forwarder-sriov that referenced this pull request Aug 30, 2021
…k-sriov@main

PR link: networkservicemesh/sdk-sriov#223

Commit: a20f8ee
Author: Denis Tingaikin
Date: 2021-08-30 10:54:47 +0300
Message:
  - Merge pull request #223 from Nordix/vfconfig-client
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants