[qfix] Fix error handling in memifproxy #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Bolodya1997
requested review from
edwarnicke,
denis-tingaikin,
glazychev-art and
Mixaster995
glazychev-art
approved these changes
Oct 12, 2021
Mixaster995
approved these changes
Oct 12, 2021
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-firewall-vpp
that referenced
this pull request
Oct 12, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#403 Commit: 792a420 Author: Vladimir Popov Date: 2021-10-12 12:01:26 +0700 Message: - Fix error handling in memifproxy (#403) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Oct 12, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#403 Commit: 792a420 Author: Vladimir Popov Date: 2021-10-12 12:01:26 +0700 Message: - Fix error handling in memifproxy (#403) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Oct 12, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#403 Commit: 792a420 Author: Vladimir Popov Date: 2021-10-12 12:01:26 +0700 Message: - Fix error handling in memifproxy (#403) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-vpp
that referenced
this pull request
Oct 12, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#403 Commit: 792a420 Author: Vladimir Popov Date: 2021-10-12 12:01:26 +0700 Message: - Fix error handling in memifproxy (#403) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Oct 12, 2021
Merged
9 tasks
Mixaster995
added a commit
to Mixaster995/sdk-vpp
that referenced
this pull request
Oct 13, 2021
This reverts commit 792a420.
Mixaster995
added a commit
to Mixaster995/sdk-vpp
that referenced
this pull request
Oct 13, 2021
This reverts commit 792a420. Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes error handling in
memifproxy.Motivation
If
erris not*net.OpErrorit doesn't return and passesnilinfurther incopymethod.Found in networkservicemesh/deployments-k8s#2381 (comment) logs:
forwarder_old_8.zip
How Has This Been Tested?
Types of changes