Revert "Fix/revert (#410)" #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d541552. Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Bolodya1997
requested review from
Mixaster995,
denis-tingaikin and
glazychev-art
denis-tingaikin
approved these changes
Oct 14, 2021
|
OK, thanks @Bolodya1997! We merged reverts yesterday to make CI green on integration tests. Will merge this PR as soon as we get a green build on kind with the latest connect merges from @edwarnicke. |
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-firewall-vpp
that referenced
this pull request
Oct 22, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#413 Commit: 2d2aa47 Author: Vladimir Popov Date: 2021-10-22 16:03:40 +0700 Message: - Revert "Fix/revert (#410)" (#413) This reverts commit d541552ca8a75892013e1a9a269a433c111053bb. Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Oct 22, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#413 Commit: 2d2aa47 Author: Vladimir Popov Date: 2021-10-22 16:03:40 +0700 Message: - Revert "Fix/revert (#410)" (#413) This reverts commit d541552ca8a75892013e1a9a269a433c111053bb. Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-vpp
that referenced
this pull request
Oct 22, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#413 Commit: 2d2aa47 Author: Vladimir Popov Date: 2021-10-22 16:03:40 +0700 Message: - Revert "Fix/revert (#410)" (#413) This reverts commit d541552ca8a75892013e1a9a269a433c111053bb. Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Oct 22, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#413 Commit: 2d2aa47 Author: Vladimir Popov Date: 2021-10-22 16:03:40 +0700 Message: - Revert "Fix/revert (#410)" (#413) This reverts commit d541552ca8a75892013e1a9a269a433c111053bb. Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Oct 22, 2021
Merged
nsmbot
pushed a commit
that referenced
this pull request
Jan 25, 2022
…k-kernel@main PR link: networkservicemesh/sdk-kernel#413 Commit: 63d40e5 Author: Denis Tingaikin Date: 2022-01-25 08:36:13 +0300 Message: - Merge pull request #413 from glazychev-art/iprule_add Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d541552.
Description
Changes are working, error was on CI because of not updated cmd-nse-firewall-vpp version.
https://github.com/networkservicemesh/deployments-k8s/blame/ae9f8f8a82b9303beab3d36d606263cf4c21b90a/images.yaml#L8
Valid version should be
68bed4e, because:Issue
Closes #411.