Fix for acl server #461
Merged
Fix for acl server #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cleanup on close Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
denis-tingaikin
approved these changes
Nov 26, 2021
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-firewall-vpp
that referenced
this pull request
Nov 26, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#461 Commit: b21fcd1 Author: Авраменко Михаил Date: 2021-11-26 19:35:30 +0700 Message: - removed recreation of acl rules on each request, and added additional cleanup on close (#461) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vlan-vpp
that referenced
this pull request
Nov 26, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#461 Commit: b21fcd1 Author: Авраменко Михаил Date: 2021-11-26 19:35:30 +0700 Message: - removed recreation of acl rules on each request, and added additional cleanup on close (#461) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Nov 26, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#461 Commit: b21fcd1 Author: Авраменко Михаил Date: 2021-11-26 19:35:30 +0700 Message: - removed recreation of acl rules on each request, and added additional cleanup on close (#461) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Nov 26, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#461 Commit: b21fcd1 Author: Авраменко Михаил Date: 2021-11-26 19:35:30 +0700 Message: - removed recreation of acl rules on each request, and added additional cleanup on close (#461) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-vpp
that referenced
this pull request
Nov 26, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#461 Commit: b21fcd1 Author: Авраменко Михаил Date: 2021-11-26 19:35:30 +0700 Message: - removed recreation of acl rules on each request, and added additional cleanup on close (#461) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mikhail Avramenko avramenkomihail15@gmail.com
Description
Removed recreation of acl rules on each request, and added additional cleanup on close
This prevents acl rules creation on each and every request (refresh/heal)
Issue
Closes networkservicemesh/deployments-k8s#2879
Unblocks networkservicemesh/deployments-k8s#3663