Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qfix] Set memif socket filename before checking #487

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

glazychev-art
Copy link
Contributor

This is to avoid empty SocketFilename mechanism parameter.

Issue: networkservicemesh/deployments-k8s#4219

Signed-off-by: Artem Glazychev artem.glazychev@xored.com

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks valid

@denis-tingaikin denis-tingaikin merged commit 443ae17 into networkservicemesh:main Jan 10, 2022
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder-vpp that referenced this pull request Jan 10, 2022
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#487

Commit: 443ae17
Author: Artem Glazychev
Date: 2022-01-10 16:45:41 +0700
Message:
  - Set memif socket filename before checking (#487)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-forwarder-vpp that referenced this pull request Jan 10, 2022
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#487

Commit: 443ae17
Author: Artem Glazychev
Date: 2022-01-10 16:45:41 +0700
Message:
  - Set memif socket filename before checking (#487)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-vpp that referenced this pull request Jan 10, 2022
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#487

Commit: 443ae17
Author: Artem Glazychev
Date: 2022-01-10 16:45:41 +0700
Message:
  - Set memif socket filename before checking (#487)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-firewall-vpp that referenced this pull request Jan 10, 2022
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#487

Commit: 443ae17
Author: Artem Glazychev
Date: 2022-01-10 16:45:41 +0700
Message:
  - Set memif socket filename before checking (#487)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vlan-vpp that referenced this pull request Jan 10, 2022
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#487

Commit: 443ae17
Author: Artem Glazychev
Date: 2022-01-10 16:45:41 +0700
Message:
  - Set memif socket filename before checking (#487)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants