Add client additional functionality option #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
denis-tingaikin
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
This option is LGTM
One moment that I see - am not sure that we should reuse whole forwarder chain for cmd-nsc-simple-docker. In some time forwarder and cmd-nse-simple-docker may have big difference.
@edwarnicke Thoughts?
|
In general this LGTM. For the particular case of reuse of the forwarder chain... in terms of reusing the forwarder chain... I think that's probably our best choice for the time being, but am open to reconsidering. |
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Jul 12, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#608 Commit: d8e03c8 Author: Artem Glazychev Date: 2022-07-13 02:44:35 +0700 Message: - Add client additional functionality option (#608) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Jul 12, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#608 Commit: d8e03c8 Author: Artem Glazychev Date: 2022-07-13 02:44:35 +0700 Message: - Add client additional functionality option (#608) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-firewall-vpp
that referenced
this pull request
Jul 12, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#608 Commit: d8e03c8 Author: Artem Glazychev Date: 2022-07-13 02:44:35 +0700 Message: - Add client additional functionality option (#608) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vl3-vpp
that referenced
this pull request
Jul 12, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#608 Commit: d8e03c8 Author: Artem Glazychev Date: 2022-07-13 02:44:35 +0700 Message: - Add client additional functionality option (#608) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vlan-vpp
that referenced
this pull request
Jul 12, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#608 Commit: d8e03c8 Author: Artem Glazychev Date: 2022-07-13 02:44:35 +0700 Message: - Add client additional functionality option (#608) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-vpp
that referenced
this pull request
Jul 12, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#608 Commit: d8e03c8 Author: Artem Glazychev Date: 2022-07-13 02:44:35 +0700 Message: - Add client additional functionality option (#608) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jul 12, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to extend the functionality of the forwarder. This may be useful for cmd-nsc-simple-docker
Issue: networkservicemesh/cmd-nsc-simple-docker#1
Signed-off-by: Artem Glazychev artem.glazychev@xored.com