Fix endless waiting in liveness check #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
NikitaSkrynnik
changed the title
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
denis-tingaikin
approved these changes
Dec 29, 2023
glazychev-art
approved these changes
Dec 29, 2023
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vl3-vpp
that referenced
this pull request
Dec 29, 2023
…k-vpp@main PR link: networkservicemesh/sdk-vpp#788 Commit: 147ddfd Author: Nikita Skrynnik Date: 2023-12-29 22:56:51 +1100 Message: - Fix endless waiting in liveness check (#788) * Add retry for routesClient + fix endless waiting in liveness check Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more fixes to vpp liveness checker Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-simple-docker
that referenced
this pull request
Dec 29, 2023
…k-vpp@main PR link: networkservicemesh/sdk-vpp#788 Commit: 147ddfd Author: Nikita Skrynnik Date: 2023-12-29 22:56:51 +1100 Message: - Fix endless waiting in liveness check (#788) * Add retry for routesClient + fix endless waiting in liveness check Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more fixes to vpp liveness checker Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Dec 29, 2023
…k-vpp@main PR link: networkservicemesh/sdk-vpp#788 Commit: 147ddfd Author: Nikita Skrynnik Date: 2023-12-29 22:56:51 +1100 Message: - Fix endless waiting in liveness check (#788) * Add retry for routesClient + fix endless waiting in liveness check Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more fixes to vpp liveness checker Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-vpp
that referenced
this pull request
Dec 29, 2023
…k-vpp@main PR link: networkservicemesh/sdk-vpp#788 Commit: 147ddfd Author: Nikita Skrynnik Date: 2023-12-29 22:56:51 +1100 Message: - Fix endless waiting in liveness check (#788) * Add retry for routesClient + fix endless waiting in liveness check Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more fixes to vpp liveness checker Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Dec 29, 2023
…k-vpp@main PR link: networkservicemesh/sdk-vpp#788 Commit: 147ddfd Author: Nikita Skrynnik Date: 2023-12-29 22:56:51 +1100 Message: - Fix endless waiting in liveness check (#788) * Add retry for routesClient + fix endless waiting in liveness check Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more fixes to vpp liveness checker Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-lb-vl3-vpp
that referenced
this pull request
Dec 29, 2023
…k-vpp@main PR link: networkservicemesh/sdk-vpp#788 Commit: 147ddfd Author: Nikita Skrynnik Date: 2023-12-29 22:56:51 +1100 Message: - Fix endless waiting in liveness check (#788) * Add retry for routesClient + fix endless waiting in liveness check Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more fixes to vpp liveness checker Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-simple-vl3-docker
that referenced
this pull request
Dec 29, 2023
…k-vpp@main PR link: networkservicemesh/sdk-vpp#788 Commit: 147ddfd Author: Nikita Skrynnik Date: 2023-12-29 22:56:51 +1100 Message: - Fix endless waiting in liveness check (#788) * Add retry for routesClient + fix endless waiting in liveness check Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more fixes to vpp liveness checker Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-firewall-vpp
that referenced
this pull request
Dec 29, 2023
…k-vpp@main PR link: networkservicemesh/sdk-vpp#788 Commit: 147ddfd Author: Nikita Skrynnik Date: 2023-12-29 22:56:51 +1100 Message: - Fix endless waiting in liveness check (#788) * Add retry for routesClient + fix endless waiting in liveness check Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more fixes to vpp liveness checker Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Dec 29, 2023
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vlan-vpp
that referenced
this pull request
Dec 29, 2023
…k-vpp@main PR link: networkservicemesh/sdk-vpp#788 Commit: 147ddfd Author: Nikita Skrynnik Date: 2023-12-29 22:56:51 +1100 Message: - Fix endless waiting in liveness check (#788) * Add retry for routesClient + fix endless waiting in liveness check Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more fixes to vpp liveness checker Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Dec 29, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
networkservicemesh/cmd-nsc-vpp#629
Description
Fix a bug with endless waiting in VPP liveness check