Trivial: Use VxlanAddDelTunnelV3 instead of V2 #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-tingaikin
approved these changes
Mar 12, 2024
rubasov
reviewed
Mar 12, 2024
| @@ -84,7 +84,7 @@ func addDel(ctx context.Context, conn *networkservice.Connection, vppConn api.Co | |||
| WithField("vppapi", "AddNodeNext").Debug("completed") | |||
|
|
|||
| now = time.Now() | |||
| vxlanAddDelTunnel := &vxlan.VxlanAddDelTunnelV2{ | |||
| vxlanAddDelTunnelV3 := &vxlan.VxlanAddDelTunnelV3{ | |||
There was a problem hiding this comment.
I believe V3 behaves the same as V2 as long as parameter is_l3 is false (which is the default):
FDio/vpp@3e38422
I'm not sure I see the point of renaming vxlanAddDelTunnel though.
There was a problem hiding this comment.
I agree, I just overreacted, and for first view looked good to rename the variable name also.
For the parameters, exactly only isL3 is the extra in V3, and by default that is false:
https://github.com/FDio/govpp/blob/master/binapi/vxlan/vxlan.ba.go#L380
VxlanAddDelTunnelV2 was deprecated (see [1]), change it to VxlanAddDelTunnelV3 and update the related log messages also. [1]: FDio/govpp@8debdf0 Signed-off-by: Lajos Katona <lajos.katona@est.tech>
elajkat
force-pushed
the
vxlanAddDelTunnelV3
branch
from
2157279 to
d2f7506
Compare
glazychev-art
approved these changes
Mar 14, 2024
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-vpp
that referenced
this pull request
Mar 14, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#805 Commit: a7d3dd6 Author: Lajos Katona Date: 2024-03-14 21:13:07 +0100 Message: - Trivial: Use VxlanAddDelTunnelV3 instead of V2 (#805) VxlanAddDelTunnelV2 was deprecated (see [1]), change it to VxlanAddDelTunnelV3 and update the related log messages also. [1]: FDio/govpp@8debdf0 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-simple-docker
that referenced
this pull request
Mar 14, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#805 Commit: a7d3dd6 Author: Lajos Katona Date: 2024-03-14 21:13:07 +0100 Message: - Trivial: Use VxlanAddDelTunnelV3 instead of V2 (#805) VxlanAddDelTunnelV2 was deprecated (see [1]), change it to VxlanAddDelTunnelV3 and update the related log messages also. [1]: FDio/govpp@8debdf0 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vlan-vpp
that referenced
this pull request
Mar 14, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#805 Commit: a7d3dd6 Author: Lajos Katona Date: 2024-03-14 21:13:07 +0100 Message: - Trivial: Use VxlanAddDelTunnelV3 instead of V2 (#805) VxlanAddDelTunnelV2 was deprecated (see [1]), change it to VxlanAddDelTunnelV3 and update the related log messages also. [1]: FDio/govpp@8debdf0 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Mar 14, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#805 Commit: a7d3dd6 Author: Lajos Katona Date: 2024-03-14 21:13:07 +0100 Message: - Trivial: Use VxlanAddDelTunnelV3 instead of V2 (#805) VxlanAddDelTunnelV2 was deprecated (see [1]), change it to VxlanAddDelTunnelV3 and update the related log messages also. [1]: FDio/govpp@8debdf0 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Mar 14, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#805 Commit: a7d3dd6 Author: Lajos Katona Date: 2024-03-14 21:13:07 +0100 Message: - Trivial: Use VxlanAddDelTunnelV3 instead of V2 (#805) VxlanAddDelTunnelV2 was deprecated (see [1]), change it to VxlanAddDelTunnelV3 and update the related log messages also. [1]: FDio/govpp@8debdf0 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-simple-vl3-docker
that referenced
this pull request
Mar 14, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#805 Commit: a7d3dd6 Author: Lajos Katona Date: 2024-03-14 21:13:07 +0100 Message: - Trivial: Use VxlanAddDelTunnelV3 instead of V2 (#805) VxlanAddDelTunnelV2 was deprecated (see [1]), change it to VxlanAddDelTunnelV3 and update the related log messages also. [1]: FDio/govpp@8debdf0 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-lb-vl3-vpp
that referenced
this pull request
Mar 14, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#805 Commit: a7d3dd6 Author: Lajos Katona Date: 2024-03-14 21:13:07 +0100 Message: - Trivial: Use VxlanAddDelTunnelV3 instead of V2 (#805) VxlanAddDelTunnelV2 was deprecated (see [1]), change it to VxlanAddDelTunnelV3 and update the related log messages also. [1]: FDio/govpp@8debdf0 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-firewall-vpp
that referenced
this pull request
Mar 14, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#805 Commit: a7d3dd6 Author: Lajos Katona Date: 2024-03-14 21:13:07 +0100 Message: - Trivial: Use VxlanAddDelTunnelV3 instead of V2 (#805) VxlanAddDelTunnelV2 was deprecated (see [1]), change it to VxlanAddDelTunnelV3 and update the related log messages also. [1]: FDio/govpp@8debdf0 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vl3-vpp
that referenced
this pull request
Mar 14, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#805 Commit: a7d3dd6 Author: Lajos Katona Date: 2024-03-14 21:13:07 +0100 Message: - Trivial: Use VxlanAddDelTunnelV3 instead of V2 (#805) VxlanAddDelTunnelV2 was deprecated (see [1]), change it to VxlanAddDelTunnelV3 and update the related log messages also. [1]: FDio/govpp@8debdf0 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Mar 14, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VxlanAddDelTunnelV2 was deprecated (see 1), change it to
VxlanAddDelTunnelV3 and update the related log messages also.
Change-Id: I018c94c0b9d1501876c5070cb3e16733eb453506
Signed-off-by: Lajos Katona lajos.katona@est.tech