Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix veth-pair creation #820

Merged

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Apr 5, 2024

Description

Due to dynamic name generation on the endpoint side, we can no longer rely on mechanism.GetInterfaceName() to remove the previous interface during healing.

Issue: networkservicemesh/integration-k8s-gke#435

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@denis-tingaikin denis-tingaikin merged commit 903fd93 into networkservicemesh:main Apr 5, 2024
13 checks passed
nsmbot pushed a commit to networkservicemesh/cmd-nsc-vpp that referenced this pull request Apr 5, 2024
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#820

Commit: 903fd93
Author: Artem Glazychev
Date: 2024-04-05 20:36:09 +0700
Message:
  - Fix veth-pair creation (#820)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-firewall-vpp that referenced this pull request Apr 5, 2024
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#820

Commit: 903fd93
Author: Artem Glazychev
Date: 2024-04-05 20:36:09 +0700
Message:
  - Fix veth-pair creation (#820)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-simple-docker that referenced this pull request Apr 5, 2024
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#820

Commit: 903fd93
Author: Artem Glazychev
Date: 2024-04-05 20:36:09 +0700
Message:
  - Fix veth-pair creation (#820)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vlan-vpp that referenced this pull request Apr 5, 2024
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#820

Commit: 903fd93
Author: Artem Glazychev
Date: 2024-04-05 20:36:09 +0700
Message:
  - Fix veth-pair creation (#820)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-simple-vl3-docker that referenced this pull request Apr 5, 2024
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#820

Commit: 903fd93
Author: Artem Glazychev
Date: 2024-04-05 20:36:09 +0700
Message:
  - Fix veth-pair creation (#820)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder-vpp that referenced this pull request Apr 5, 2024
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#820

Commit: 903fd93
Author: Artem Glazychev
Date: 2024-04-05 20:36:09 +0700
Message:
  - Fix veth-pair creation (#820)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-forwarder-vpp that referenced this pull request Apr 5, 2024
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#820

Commit: 903fd93
Author: Artem Glazychev
Date: 2024-04-05 20:36:09 +0700
Message:
  - Fix veth-pair creation (#820)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-lb-vl3-vpp that referenced this pull request Apr 5, 2024
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#820

Commit: 903fd93
Author: Artem Glazychev
Date: 2024-04-05 20:36:09 +0700
Message:
  - Fix veth-pair creation (#820)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vl3-vpp that referenced this pull request Apr 5, 2024
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#820

Commit: 903fd93
Author: Artem Glazychev
Date: 2024-04-05 20:36:09 +0700
Message:
  - Fix veth-pair creation (#820)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants