-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix veth-pair creation #820
Merged
denis-tingaikin
merged 1 commit into
networkservicemesh:main
from
glazychev-art:veth_pair_name
Apr 5, 2024
Merged
Fix veth-pair creation #820
denis-tingaikin
merged 1 commit into
networkservicemesh:main
from
glazychev-art:veth_pair_name
Apr 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
glazychev-art
force-pushed
the
veth_pair_name
branch
from
April 5, 2024 12:27
01913fe
to
1e91c9a
Compare
denis-tingaikin
approved these changes
Apr 5, 2024
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-vpp
that referenced
this pull request
Apr 5, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#820 Commit: 903fd93 Author: Artem Glazychev Date: 2024-04-05 20:36:09 +0700 Message: - Fix veth-pair creation (#820) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-firewall-vpp
that referenced
this pull request
Apr 5, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#820 Commit: 903fd93 Author: Artem Glazychev Date: 2024-04-05 20:36:09 +0700 Message: - Fix veth-pair creation (#820) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-simple-docker
that referenced
this pull request
Apr 5, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#820 Commit: 903fd93 Author: Artem Glazychev Date: 2024-04-05 20:36:09 +0700 Message: - Fix veth-pair creation (#820) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vlan-vpp
that referenced
this pull request
Apr 5, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#820 Commit: 903fd93 Author: Artem Glazychev Date: 2024-04-05 20:36:09 +0700 Message: - Fix veth-pair creation (#820) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-simple-vl3-docker
that referenced
this pull request
Apr 5, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#820 Commit: 903fd93 Author: Artem Glazychev Date: 2024-04-05 20:36:09 +0700 Message: - Fix veth-pair creation (#820) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Apr 5, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#820 Commit: 903fd93 Author: Artem Glazychev Date: 2024-04-05 20:36:09 +0700 Message: - Fix veth-pair creation (#820) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Apr 5, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#820 Commit: 903fd93 Author: Artem Glazychev Date: 2024-04-05 20:36:09 +0700 Message: - Fix veth-pair creation (#820) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-lb-vl3-vpp
that referenced
this pull request
Apr 5, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#820 Commit: 903fd93 Author: Artem Glazychev Date: 2024-04-05 20:36:09 +0700 Message: - Fix veth-pair creation (#820) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vl3-vpp
that referenced
this pull request
Apr 5, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#820 Commit: 903fd93 Author: Artem Glazychev Date: 2024-04-05 20:36:09 +0700 Message: - Fix veth-pair creation (#820) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Apr 5, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to dynamic name generation on the endpoint side, we can no longer rely on
mechanism.GetInterfaceName()
to remove the previous interface during healing.Issue: networkservicemesh/integration-k8s-gke#435