Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize heal tests #375

Closed
denis-tingaikin opened this issue Jul 9, 2020 · 4 comments · Fixed by #642
Closed

Stabilize heal tests #375

denis-tingaikin opened this issue Jul 9, 2020 · 4 comments · Fixed by #642
Assignees
@edwarnicke @artem-belov
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@denis-tingaikin
Copy link
Member

denis-tingaikin commented Jul 9, 2020 •
edited
Loading

Problem statement

After the latest merges, we faced new unstable heal tests:

TestHealClient_Request
TestNewClient_MissingConnectionsInInit

Logs

=== Failed
=== FAIL: pkg/networkservice/common/heal TestHealClient_Request (0.07s)
    client_test.go:116: 
        	Error Trace:	client_test.go:116
        	Error:      	Condition never satisfied
        	Test:       	TestHealClient_Request

=== FAIL: pkg/networkservice/common/heal TestNewClient_MissingConnectionsInInit (0.12s)
    client_test.go:217: 
        	Error Trace:	client_test.go:217
        	Error:      	Condition never satisfied
        	Test:       	TestNewClient_MissingConnectionsInInit

Link to CI job

https://github.com/networkservicemesh/sdk/runs/854630760?check_suite_focus=true
@denis-tingaikin
Copy link
Member Author

denis-tingaikin commented Jul 9, 2020 •
edited
Loading

https://github.com/networkservicemesh/sdk/runs/854581819?check_suite_focus=true

@denis-tingaikin denis-tingaikin added the bug Something isn't working label Jul 14, 2020
@denis-tingaikin
Copy link
Member Author

@haiodo Looks like delay has not helped https://github.com/networkservicemesh/sdk/runs/893129856

@denis-tingaikin denis-tingaikin added the good first issue Good for newcomers label Jul 23, 2020
@xzfc
Copy link
Contributor

xzfc commented Sep 29, 2020

TestHealClient_Request is being fixed in #493 by @edwarnicke.

I'll take a look at TestNewClient_MissingConnectionsInInit which is disabled at the moment.

@edwarnicke
Copy link
Member

@xzfc Certainly trying to track the issue down :)

@Bolodya1997 Bolodya1997 mentioned this issue Oct 14, 2020
Merged
@denis-tingaikin denis-tingaikin assigned edwarnicke and unassigned xzfc Oct 27, 2020
@artem-belov artem-belov mentioned this issue Jan 12, 2021
Merged
@artem-belov artem-belov self-assigned this Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edwarnicke edwarnicke

@artem-belov artem-belov

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stabilize heal tests artem-belov/sdk
4 participants
@edwarnicke @xzfc @artem-belov @denis-tingaikin