Stabilize heal tests #642
Merged
Stabilize heal tests #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 12, 2021 14:40
Signed-off-by: Artem Belov <artem.belov@xored.com>
Signed-off-by: Artem Belov <artem.belov@xored.com>
Signed-off-by: Artem Belov <artem.belov@xored.com>
Signed-off-by: Artem Belov <artem.belov@xored.com>
haiodo
approved these changes
Jan 15, 2021
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder
that referenced
this pull request
Jan 15, 2021
…k@master networkservicemesh/sdk#642 networkservicemesh/sdk PR link: networkservicemesh/sdk#642 networkservicemesh/sdk commit message: commit 35af2e4e173cceccf108c1b32c6cb26402b44bb3 Author: Artem Belov <artem.belov@xored.com> Date: Fri Jan 15 14:05:45 2021 +0700 Stabilize heal tests (#642) * Fix TestHealClient_Request Signed-off-by: Artem Belov <artem.belov@xored.com> * Remove TestNewClient_MissingConnectionsInInit test Signed-off-by: Artem Belov <artem.belov@xored.com> * Add more comments Signed-off-by: Artem Belov <artem.belov@xored.com> * Fix go lint Signed-off-by: Artem Belov <artem.belov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Jan 15, 2021
…k@master networkservicemesh/sdk#642 networkservicemesh/sdk PR link: networkservicemesh/sdk#642 networkservicemesh/sdk commit message: commit 35af2e4e173cceccf108c1b32c6cb26402b44bb3 Author: Artem Belov <artem.belov@xored.com> Date: Fri Jan 15 14:05:45 2021 +0700 Stabilize heal tests (#642) * Fix TestHealClient_Request Signed-off-by: Artem Belov <artem.belov@xored.com> * Remove TestNewClient_MissingConnectionsInInit test Signed-off-by: Artem Belov <artem.belov@xored.com> * Add more comments Signed-off-by: Artem Belov <artem.belov@xored.com> * Fix go lint Signed-off-by: Artem Belov <artem.belov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Jan 15, 2021
…k@master networkservicemesh/sdk#642 networkservicemesh/sdk PR link: networkservicemesh/sdk#642 networkservicemesh/sdk commit message: commit 35af2e4e173cceccf108c1b32c6cb26402b44bb3 Author: Artem Belov <artem.belov@xored.com> Date: Fri Jan 15 14:05:45 2021 +0700 Stabilize heal tests (#642) * Fix TestHealClient_Request Signed-off-by: Artem Belov <artem.belov@xored.com> * Remove TestNewClient_MissingConnectionsInInit test Signed-off-by: Artem Belov <artem.belov@xored.com> * Add more comments Signed-off-by: Artem Belov <artem.belov@xored.com> * Fix go lint Signed-off-by: Artem Belov <artem.belov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Jan 15, 2021
…k@master networkservicemesh/sdk#642 networkservicemesh/sdk PR link: networkservicemesh/sdk#642 networkservicemesh/sdk commit message: commit 35af2e4e173cceccf108c1b32c6cb26402b44bb3 Author: Artem Belov <artem.belov@xored.com> Date: Fri Jan 15 14:05:45 2021 +0700 Stabilize heal tests (#642) * Fix TestHealClient_Request Signed-off-by: Artem Belov <artem.belov@xored.com> * Remove TestNewClient_MissingConnectionsInInit test Signed-off-by: Artem Belov <artem.belov@xored.com> * Add more comments Signed-off-by: Artem Belov <artem.belov@xored.com> * Fix go lint Signed-off-by: Artem Belov <artem.belov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Jan 15, 2021
…k@master networkservicemesh/sdk#642 networkservicemesh/sdk PR link: networkservicemesh/sdk#642 networkservicemesh/sdk commit message: commit 35af2e4e173cceccf108c1b32c6cb26402b44bb3 Author: Artem Belov <artem.belov@xored.com> Date: Fri Jan 15 14:05:45 2021 +0700 Stabilize heal tests (#642) * Fix TestHealClient_Request Signed-off-by: Artem Belov <artem.belov@xored.com> * Remove TestNewClient_MissingConnectionsInInit test Signed-off-by: Artem Belov <artem.belov@xored.com> * Add more comments Signed-off-by: Artem Belov <artem.belov@xored.com> * Fix go lint Signed-off-by: Artem Belov <artem.belov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Jan 15, 2021
…k@master networkservicemesh/sdk#642 networkservicemesh/sdk PR link: networkservicemesh/sdk#642 networkservicemesh/sdk commit message: commit 35af2e4e173cceccf108c1b32c6cb26402b44bb3 Author: Artem Belov <artem.belov@xored.com> Date: Fri Jan 15 14:05:45 2021 +0700 Stabilize heal tests (#642) * Fix TestHealClient_Request Signed-off-by: Artem Belov <artem.belov@xored.com> * Remove TestNewClient_MissingConnectionsInInit test Signed-off-by: Artem Belov <artem.belov@xored.com> * Add more comments Signed-off-by: Artem Belov <artem.belov@xored.com> * Fix go lint Signed-off-by: Artem Belov <artem.belov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Jan 15, 2021
…k@master networkservicemesh/sdk#642 networkservicemesh/sdk PR link: networkservicemesh/sdk#642 networkservicemesh/sdk commit message: commit 35af2e4e173cceccf108c1b32c6cb26402b44bb3 Author: Artem Belov <artem.belov@xored.com> Date: Fri Jan 15 14:05:45 2021 +0700 Stabilize heal tests (#642) * Fix TestHealClient_Request Signed-off-by: Artem Belov <artem.belov@xored.com> * Remove TestNewClient_MissingConnectionsInInit test Signed-off-by: Artem Belov <artem.belov@xored.com> * Add more comments Signed-off-by: Artem Belov <artem.belov@xored.com> * Fix go lint Signed-off-by: Artem Belov <artem.belov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-vppagent
that referenced
this pull request
Jan 15, 2021
…k@master networkservicemesh/sdk#642 networkservicemesh/sdk PR link: networkservicemesh/sdk#642 networkservicemesh/sdk commit message: commit 35af2e4e173cceccf108c1b32c6cb26402b44bb3 Author: Artem Belov <artem.belov@xored.com> Date: Fri Jan 15 14:05:45 2021 +0700 Stabilize heal tests (#642) * Fix TestHealClient_Request Signed-off-by: Artem Belov <artem.belov@xored.com> * Remove TestNewClient_MissingConnectionsInInit test Signed-off-by: Artem Belov <artem.belov@xored.com> * Add more comments Signed-off-by: Artem Belov <artem.belov@xored.com> * Fix go lint Signed-off-by: Artem Belov <artem.belov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Jan 15, 2021
…k@master networkservicemesh/sdk#642 networkservicemesh/sdk PR link: networkservicemesh/sdk#642 networkservicemesh/sdk commit message: commit 35af2e4e173cceccf108c1b32c6cb26402b44bb3 Author: Artem Belov <artem.belov@xored.com> Date: Fri Jan 15 14:05:45 2021 +0700 Stabilize heal tests (#642) * Fix TestHealClient_Request Signed-off-by: Artem Belov <artem.belov@xored.com> * Remove TestNewClient_MissingConnectionsInInit test Signed-off-by: Artem Belov <artem.belov@xored.com> * Add more comments Signed-off-by: Artem Belov <artem.belov@xored.com> * Fix go lint Signed-off-by: Artem Belov <artem.belov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jan 15, 2021
nsmbot
pushed a commit
to networkservicemesh/sdk-vpp
that referenced
this pull request
Jan 15, 2021
…k@master networkservicemesh/sdk#642 networkservicemesh/sdk PR link: networkservicemesh/sdk#642 networkservicemesh/sdk commit message: commit 35af2e4e173cceccf108c1b32c6cb26402b44bb3 Author: Artem Belov <artem.belov@xored.com> Date: Fri Jan 15 14:05:45 2021 +0700 Stabilize heal tests (#642) * Fix TestHealClient_Request Signed-off-by: Artem Belov <artem.belov@xored.com> * Remove TestNewClient_MissingConnectionsInInit test Signed-off-by: Artem Belov <artem.belov@xored.com> * Add more comments Signed-off-by: Artem Belov <artem.belov@xored.com> * Fix go lint Signed-off-by: Artem Belov <artem.belov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #375
TestHealClient_Request- removed firstMonitorConnectionswith the calls context to avoid Server to send commands to almost canceled context.TestNewClient_MissingConnectionsInInit- test removed. Heal client has a check that the expected connection was received and return an error onRequestotherwise.