qfix: DNSNSEResolve server should correctly translate NSE for floating side and for querying side

[denis-tingaikin]

Signed-off-by: Denis Tingaikin denis.tingajkin@xored.com

Description

Problem scenario:

1. NSE "nse-1@floating" registers in the floating domain with labels: "ns-1@floating" : {"app": "myapp"}.
2. NSE "nse" registered in floating registry with labels: "ns-1@floating" : {"app": "myapp"}
3. Call Find request "nse-1@floaing" on local registry.

Actual: Returned nse-1 with labels: "ns-1@floating" : {"app": "myapp"}
Expected: Returned nse-1@floating with labels: "ns-1@floaitng" : {"app": "myapp"}

How Has This Been Tested?

• Added unit testing to cover
• Tested manually
• Tested by integration testing
• Have not tested

Types of changes

• Bug fix
• New functionallity
• Documentation
• Refactoring
• CI

[edwarnicke]

I'm a little confused... we is something registering in domain @floating showing up in our local registry as a local ns?

[denis-tingaikin]

@edwarnicke Its about using Find on local registry with interdomain queries.

For example,

Use-case:

1. Register NSE (note: actually we register NSE in floating registry)

NSE{
  name: "nse-1@floating"
  labels: "ns-1@floating": {"label1": label2}
}

2. Call find nse-1@floating

Actual response:

NSE{
  name: "nse-1"
  labels: "ns-1@floating": {"label1": label2}
}

Expected response:

NSE{
  name: "nse-1"
  labels: "ns-1": {"label1": label2}
}

This patch makes actual = expected.

[edwarnicke]

Your actual response is what I would have expected... why do you expect the response to clip the domain out of a label?

[denis-tingaikin]

By my view it could affect discover chain element, because it will not able to match ns by labels.

[edwarnicke]

@denis-tingaikin Could you say more about that, I don't see it... the ns you are looking for is ns-1@floating ... you aren't looking for ns-1 in your local registry... that's a different ns...

[denis-tingaikin]

@edwarnicke Many thanks for the internal clarification. I've provided a patch that makes the next behavior for floating registry queries from the client side of local registry.