Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eventchannel networkservice chain element #105

Merged
merged 1 commit into from
Feb 16, 2020

Conversation

edwarnicke
Copy link
Member

This provides machinery to allow the creation of various MonitorConnection clients/servers backed
by event channels. This aids in construction of both adapters and the building of tests.

This provides machinery to allow the creation of various MonitorConnection clients/servers backed
by event channels.  This aids in construction of both adapters and the building of tests.

Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Copy link
Member

@fkautz fkautz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to keep reviewing this a bit more, want to make sure we get this as right as possible.

@fkautz fkautz merged commit b0081ad into networkservicemesh:master Feb 16, 2020
denis-tingaikin pushed a commit that referenced this pull request Jun 18, 2021
…i@main networkservicemesh/api#

networkservicemesh/api PR link: https://github.com/networkservicemesh/api/pull/

networkservicemesh/api commit message:
commit e3fc29dc170b11a80aced6e7ae9f42229dcabedd
Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com>
Date:   Sat Jun 19 01:43:50 2021 +0700

    fix: push tag on a release branch before creating release (#105)

    * fix: push tag on a release before creating release

    Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>

    * fix linter issue

    Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants