[deployments-k8s#2393] Rework sandbox.DefaultDialOptions to sandbox.DialOptions with options #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bolodya1997
force-pushed
the
deployments-k8s#2393/dial-options
branch
from
5afa180 to
98dbe8b
Compare
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Bolodya1997
force-pushed
the
deployments-k8s#2393/dial-options
branch
from
98dbe8b to
8977a17
Compare
Bolodya1997
requested review from
denis-tingaikin,
Mixaster995 and
glazychev-art
Mixaster995
approved these changes
Aug 10, 2021
denis-tingaikin
approved these changes
Aug 11, 2021
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Aug 11, 2021
…k@main PR link: networkservicemesh/sdk#1059 Commit: 74e4c20 Author: Vladimir Popov Date: 2021-08-11 21:18:37 +0700 Message: - Rework sandbox.DefaultDialOptions to sandbox.DialOptions with options (#1059) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Aug 11, 2021
…k@main PR link: networkservicemesh/sdk#1059 Commit: 74e4c20 Author: Vladimir Popov Date: 2021-08-11 21:18:37 +0700 Message: - Rework sandbox.DefaultDialOptions to sandbox.DialOptions with options (#1059) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Aug 11, 2021
…k@main PR link: networkservicemesh/sdk#1059 Commit: 74e4c20 Author: Vladimir Popov Date: 2021-08-11 21:18:37 +0700 Message: - Rework sandbox.DefaultDialOptions to sandbox.DialOptions with options (#1059) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Aug 11, 2021
…k@main PR link: networkservicemesh/sdk#1059 Commit: 74e4c20 Author: Vladimir Popov Date: 2021-08-11 21:18:37 +0700 Message: - Rework sandbox.DefaultDialOptions to sandbox.DialOptions with options (#1059) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Aug 11, 2021
…k@main PR link: networkservicemesh/sdk#1059 Commit: 74e4c20 Author: Vladimir Popov Date: 2021-08-11 21:18:37 +0700 Message: - Rework sandbox.DefaultDialOptions to sandbox.DialOptions with options (#1059) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder
that referenced
this pull request
Aug 11, 2021
…k@main PR link: networkservicemesh/sdk#1059 Commit: 74e4c20 Author: Vladimir Popov Date: 2021-08-11 21:18:37 +0700 Message: - Rework sandbox.DefaultDialOptions to sandbox.DialOptions with options (#1059) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Aug 11, 2021
…k@main PR link: networkservicemesh/sdk#1059 Commit: 74e4c20 Author: Vladimir Popov Date: 2021-08-11 21:18:37 +0700 Message: - Rework sandbox.DefaultDialOptions to sandbox.DialOptions with options (#1059) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Aug 11, 2021
…k@main PR link: networkservicemesh/sdk#1059 Commit: 74e4c20 Author: Vladimir Popov Date: 2021-08-11 21:18:37 +0700 Message: - Rework sandbox.DefaultDialOptions to sandbox.DialOptions with options (#1059) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Aug 11, 2021
…k@main PR link: networkservicemesh/sdk#1059 Commit: 74e4c20 Author: Vladimir Popov Date: 2021-08-11 21:18:37 +0700 Message: - Rework sandbox.DefaultDialOptions to sandbox.DialOptions with options (#1059) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reworks
sandbox.DefaultDialOptionstosandbox.DialOptionswith options pattern.Issue link
Needed for networkservicemesh/deployments-k8s#2393.
How Has This Been Tested?
Added unit testing to coverCovered by existing unit testingTypes of changes