Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qfix] Fix client chain order #1065

Merged
merged 1 commit into from
Aug 16, 2021
Merged

[qfix] Fix client chain order #1065

merged 1 commit into from
Aug 16, 2021

Conversation

Bolodya1997
Copy link

@Bolodya1997 Bolodya1997 commented Aug 13, 2021 •
edited
Loading

Description

In heal we are taking the right most connection and trying to use it for the left most chain element, so how it looks in Forwarder chain:

... -> mechanisms server -> ... -> mechanism translation client -> ... -> heal client -> gRPC client

Until #1039 it was slightly different:

... -> mechanisms server -> ... -> heal client -> mechanism translation client -> ... -> gRPC client
  1. heal tries to close server chain using client mechanism
  2. instead of closing kerneltap and cleaning kernel interface, it closes vxlan and just does nothing
  3. upcoming Request fails when trying to create a new kernel interface with already existing name

Doesn't look like we can easily solve this issue without a begin chain element, so we probably can revert some last changes and wait for the begin to be created.

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

Fix client chain order
7faa894 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
@Bolodya1997 Bolodya1997 marked this pull request as ready for review August 13, 2021 11:38
@Bolodya1997 Bolodya1997 mentioned this pull request Aug 13, 2021
Merged
@denis-tingaikin denis-tingaikin merged commit 11fd14b into networkservicemesh:main Aug 16, 2021
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Aug 16, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9c0d364 
…k@main

PR link: networkservicemesh/sdk#1065

Commit: 11fd14b
Author: Vladimir Popov
Date: 2021-08-16 13:00:13 +0700
Message:
  - Fix client chain order (#1065)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder that referenced this pull request Aug 16, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b7f5784 
…k@main

PR link: networkservicemesh/sdk#1065

Commit: 11fd14b
Author: Vladimir Popov
Date: 2021-08-16 13:00:13 +0700
Message:
  - Fix client chain order (#1065)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Aug 16, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
fa96e18 
…k@main

PR link: networkservicemesh/sdk#1065

Commit: 11fd14b
Author: Vladimir Popov
Date: 2021-08-16 13:00:13 +0700
Message:
  - Fix client chain order (#1065)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Aug 16, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
7930047 
…k@main

PR link: networkservicemesh/sdk#1065

Commit: 11fd14b
Author: Vladimir Popov
Date: 2021-08-16 13:00:13 +0700
Message:
  - Fix client chain order (#1065)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Aug 16, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d53dcf1 
…k@main

PR link: networkservicemesh/sdk#1065

Commit: 11fd14b
Author: Vladimir Popov
Date: 2021-08-16 13:00:13 +0700
Message:
  - Fix client chain order (#1065)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Aug 16, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
36b6a84 
…k@main

PR link: networkservicemesh/sdk#1065

Commit: 11fd14b
Author: Vladimir Popov
Date: 2021-08-16 13:00:13 +0700
Message:
  - Fix client chain order (#1065)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Aug 16, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1f625f1 
…k@main

PR link: networkservicemesh/sdk#1065

Commit: 11fd14b
Author: Vladimir Popov
Date: 2021-08-16 13:00:13 +0700
Message:
  - Fix client chain order (#1065)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Aug 16, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8918517 
…k@main

PR link: networkservicemesh/sdk#1065

Commit: 11fd14b
Author: Vladimir Popov
Date: 2021-08-16 13:00:13 +0700
Message:
  - Fix client chain order (#1065)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Aug 16, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1623ccd 
…k@main

PR link: networkservicemesh/sdk#1065

Commit: 11fd14b
Author: Vladimir Popov
Date: 2021-08-16 13:00:13 +0700
Message:
  - Fix client chain order (#1065)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Aug 16, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@edwarnicke
Copy link
Member

Good catch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@glazychev-art glazychev-art glazychev-art approved these changes

@Mixaster995 Mixaster995 Awaiting requested review from Mixaster995

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bolodya1997 @edwarnicke @glazychev-art @denis-tingaikin