fix: Actualise authorize server with latest main branch changes #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
actualize-authorize-server
branch
from
ea2e5dd to
379a079
Compare
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder
that referenced
this pull request
Aug 22, 2021
…k@main PR link: networkservicemesh/sdk#1071 Commit: 49be40e Author: Denis Tingaikin Date: 2021-08-22 03:26:59 +0300 Message: - actualise authorize server with latest main changes (#1071) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Aug 22, 2021
…k@main PR link: networkservicemesh/sdk#1071 Commit: 49be40e Author: Denis Tingaikin Date: 2021-08-22 03:26:59 +0300 Message: - actualise authorize server with latest main changes (#1071) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Aug 22, 2021
…k@main PR link: networkservicemesh/sdk#1071 Commit: 49be40e Author: Denis Tingaikin Date: 2021-08-22 03:26:59 +0300 Message: - actualise authorize server with latest main changes (#1071) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Aug 22, 2021
…k@main PR link: networkservicemesh/sdk#1071 Commit: 49be40e Author: Denis Tingaikin Date: 2021-08-22 03:26:59 +0300 Message: - actualise authorize server with latest main changes (#1071) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Aug 22, 2021
…k@main PR link: networkservicemesh/sdk#1071 Commit: 49be40e Author: Denis Tingaikin Date: 2021-08-22 03:26:59 +0300 Message: - actualise authorize server with latest main changes (#1071) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Aug 22, 2021
…k@main PR link: networkservicemesh/sdk#1071 Commit: 49be40e Author: Denis Tingaikin Date: 2021-08-22 03:26:59 +0300 Message: - actualise authorize server with latest main changes (#1071) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Aug 22, 2021
…k@main PR link: networkservicemesh/sdk#1071 Commit: 49be40e Author: Denis Tingaikin Date: 2021-08-22 03:26:59 +0300 Message: - actualise authorize server with latest main changes (#1071) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Aug 22, 2021
…k@main PR link: networkservicemesh/sdk#1071 Commit: 49be40e Author: Denis Tingaikin Date: 2021-08-22 03:26:59 +0300 Message: - actualise authorize server with latest main changes (#1071) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Aug 22, 2021
…k@main PR link: networkservicemesh/sdk#1071 Commit: 49be40e Author: Denis Tingaikin Date: 2021-08-22 03:26:59 +0300 Message: - actualise authorize server with latest main changes (#1071) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Aug 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1018 was outdated with the main branch.
For example,
path.Index for the client in the main branch for the first client is 0 (previously it was 1).
heal can trigger authrorize server without peer in the context. In this case authorizer server should allow the request.
Issue link
Fixes networkservicemesh/integration-k8s-kind#354
How Has This Been Tested?
Types of changes