Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdk-vpp#314] Add endpoint.Combine #1077

Merged
merged 1 commit into from
Sep 14, 2021
Merged

[sdk-vpp#314] Add endpoint.Combine #1077

merged 1 commit into from
Sep 14, 2021

Conversation

Bolodya1997
Copy link

Description

Adds a new utility method to merge multiple endpoint.Endpoint in a single one.

Example of usage to merge SR-IOV forwarder and VPP forwarder endpoints in a single one - https://github.com/networkservicemesh/cmd-forwarder-vpp/blob/d50f7aab7dde0350e91509eb182784dc3b6a29fb/internal/xconnectns/server.go

Issue link

networkservicemesh/sdk-vpp#314

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

Add endpoint.Combine
67aff81 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
@Bolodya1997 Bolodya1997 mentioned this pull request Sep 13, 2021
Merged
9 tasks
@edwarnicke edwarnicke merged commit 07ced33 into networkservicemesh:main Sep 14, 2021
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Sep 14, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
122cdd6 
…k@main

PR link: networkservicemesh/sdk#1077

Commit: 07ced33
Author: Vladimir Popov
Date: 2021-09-14 21:03:53 +0700
Message:
  - Add endpoint.Combine (#1077)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Sep 14, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
164e672 
…k@main

PR link: networkservicemesh/sdk#1077

Commit: 07ced33
Author: Vladimir Popov
Date: 2021-09-14 21:03:53 +0700
Message:
  - Add endpoint.Combine (#1077)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Sep 14, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b592acc 
…k@main

PR link: networkservicemesh/sdk#1077

Commit: 07ced33
Author: Vladimir Popov
Date: 2021-09-14 21:03:53 +0700
Message:
  - Add endpoint.Combine (#1077)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Sep 14, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
64ef782 
…k@main

PR link: networkservicemesh/sdk#1077

Commit: 07ced33
Author: Vladimir Popov
Date: 2021-09-14 21:03:53 +0700
Message:
  - Add endpoint.Combine (#1077)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Sep 14, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
928b555 
…k@main

PR link: networkservicemesh/sdk#1077

Commit: 07ced33
Author: Vladimir Popov
Date: 2021-09-14 21:03:53 +0700
Message:
  - Add endpoint.Combine (#1077)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder that referenced this pull request Sep 14, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c875af5 
…k@main

PR link: networkservicemesh/sdk#1077

Commit: 07ced33
Author: Vladimir Popov
Date: 2021-09-14 21:03:53 +0700
Message:
  - Add endpoint.Combine (#1077)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Sep 14, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c201c44 
…k@main

PR link: networkservicemesh/sdk#1077

Commit: 07ced33
Author: Vladimir Popov
Date: 2021-09-14 21:03:53 +0700
Message:
  - Add endpoint.Combine (#1077)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Sep 14, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8047293 
…k@main

PR link: networkservicemesh/sdk#1077

Commit: 07ced33
Author: Vladimir Popov
Date: 2021-09-14 21:03:53 +0700
Message:
  - Add endpoint.Combine (#1077)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Sep 14, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d042e60 
…k@main

PR link: networkservicemesh/sdk#1077

Commit: 07ced33
Author: Vladimir Popov
Date: 2021-09-14 21:03:53 +0700
Message:
  - Add endpoint.Combine (#1077)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Sep 14, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin Awaiting requested review from denis-tingaikin

@edwarnicke edwarnicke Awaiting requested review from edwarnicke

@glazychev-art glazychev-art Awaiting requested review from glazychev-art

@Mixaster995 Mixaster995 Awaiting requested review from Mixaster995

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bolodya1997 @edwarnicke