Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make vxlan port configurable #1091

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Make vxlan port configurable #1091

merged 1 commit into from
Sep 29, 2021

Conversation

zolug
Copy link
Contributor

@zolug zolug commented Sep 29, 2021

Signed-off-by: Zoltan Lugossy zoltan.lugossy@est.tech

Description

Issue link

networkservicemesh/cmd-forwarder-vpp#341

How Has This Been Tested?

  • [ x] Added unit testing to cover
  • [ x] Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • [ x] New functionallity
  • Documentation
  • Refactoring
  • CI

zolug added a commit to Nordix/nsm-sdk-vpp that referenced this pull request Sep 29, 2021
@zolug
Make vxlan port configurable
40672c0 
networkservicemesh/sdk commit message:
Make vxlan port configurable (see networkservicemesh/sdk#1091)

Signed-off-by: Zoltan Lugossy <zoltan.lugossy@est.tech>
zolug added a commit to Nordix/nsm-cmd-forwarder-vpp that referenced this pull request Sep 29, 2021
@zolug
Make vxlan port configurable (networkservicemesh#341)
12e0a0a 
networkservicemesh/sdk-vpp commit message:
Make vxlan port configurable (see networkservicemesh/sdk-vpp#394)

networkservicemesh/sdk commit message:
Make vxlan port configurable (see networkservicemesh/sdk#1091)

Signed-off-by: Zoltan Lugossy <zoltan.lugossy@est.tech>
edwarnicke
edwarnicke reviewed Sep 29, 2021
View reviewed changes
pkg/networkservice/common/mechanisms/vxlan/vni/client.go Outdated
}

// NewClient - set the SrcIP for the vxlan mechanism
func NewClient(tunnelIP net.IP) networkservice.NetworkServiceClient {
func NewClient(tunnelIP net.IP, tunnelPort uint16) networkservice.NetworkServiceClient {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use the Option pattern here for tunnelPort?

@zolug
Make vxlan port configurable
b312ac9 
Signed-off-by: Zoltan Lugossy <zoltan.lugossy@est.tech>
zolug added a commit to Nordix/nsm-sdk-vpp that referenced this pull request Sep 29, 2021
@zolug
Make vxlan port configurable
b50d63c 
networkservicemesh/sdk commit message:
Make vxlan port configurable (see networkservicemesh/sdk#1091)

Signed-off-by: Zoltan Lugossy <zoltan.lugossy@est.tech>
zolug added a commit to Nordix/nsm-cmd-forwarder-vpp that referenced this pull request Sep 29, 2021
@zolug
Make vxlan port configurable (networkservicemesh#341)
ae6006d 
networkservicemesh/sdk-vpp commit message:
Make vxlan port configurable (see networkservicemesh/sdk-vpp#394)

networkservicemesh/sdk commit message:
Make vxlan port configurable (see networkservicemesh/sdk#1091)

Signed-off-by: Zoltan Lugossy <zoltan.lugossy@est.tech>
@edwarnicke edwarnicke merged commit ec235de into networkservicemesh:main Sep 29, 2021
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Sep 29, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9f3430d 
…k@main

PR link: networkservicemesh/sdk#1091

Commit: ec235de
Author: zolug
Date: 2021-09-29 20:04:27 +0200
Message:
  - Make vxlan port configurable (#1091)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Sep 29, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
3bb0f35 
…k@main

PR link: networkservicemesh/sdk#1091

Commit: ec235de
Author: zolug
Date: 2021-09-29 20:04:27 +0200
Message:
  - Make vxlan port configurable (#1091)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Sep 29, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8dd6236 
…k@main

PR link: networkservicemesh/sdk#1091

Commit: ec235de
Author: zolug
Date: 2021-09-29 20:04:27 +0200
Message:
  - Make vxlan port configurable (#1091)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Sep 29, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
90973da 
…k@main

PR link: networkservicemesh/sdk#1091

Commit: ec235de
Author: zolug
Date: 2021-09-29 20:04:27 +0200
Message:
  - Make vxlan port configurable (#1091)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Sep 29, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
acde828 
…k@main

PR link: networkservicemesh/sdk#1091

Commit: ec235de
Author: zolug
Date: 2021-09-29 20:04:27 +0200
Message:
  - Make vxlan port configurable (#1091)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Sep 29, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
deb6c94 
…k@main

PR link: networkservicemesh/sdk#1091

Commit: ec235de
Author: zolug
Date: 2021-09-29 20:04:27 +0200
Message:
  - Make vxlan port configurable (#1091)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Sep 29, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
02c395c 
…k@main

PR link: networkservicemesh/sdk#1091

Commit: ec235de
Author: zolug
Date: 2021-09-29 20:04:27 +0200
Message:
  - Make vxlan port configurable (#1091)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Sep 29, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b5a44bf 
…k@main

PR link: networkservicemesh/sdk#1091

Commit: ec235de
Author: zolug
Date: 2021-09-29 20:04:27 +0200
Message:
  - Make vxlan port configurable (#1091)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Sep 29, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
zolug added a commit to Nordix/nsm-sdk-vpp that referenced this pull request Sep 30, 2021
@zolug
Make vxlan port configurable
06e2fb3 
networkservicemesh/sdk commit message:
Make vxlan port configurable (see networkservicemesh/sdk#1091)

Signed-off-by: Zoltan Lugossy <zoltan.lugossy@est.tech>
zolug added a commit to Nordix/nsm-cmd-forwarder-vpp that referenced this pull request Sep 30, 2021
@zolug
Make vxlan port configurable (networkservicemesh#341)
076c128 
networkservicemesh/sdk-vpp commit message:
Make vxlan port configurable (see networkservicemesh/sdk-vpp#394)

networkservicemesh/sdk commit message:
Make vxlan port configurable (see networkservicemesh/sdk#1091)

Signed-off-by: Zoltan Lugossy <zoltan.lugossy@est.tech>
zolug added a commit to Nordix/nsm-sdk-vpp that referenced this pull request Sep 30, 2021
@zolug
Make vxlan port configurable
58e4c41 
networkservicemesh/sdk commit message:
Make vxlan port configurable (see networkservicemesh/sdk#1091)

Signed-off-by: Zoltan Lugossy <zoltan.lugossy@est.tech>
zolug added a commit to Nordix/nsm-sdk-vpp that referenced this pull request Sep 30, 2021
@zolug
Make vxlan port configurable
a861818 
networkservicemesh/sdk commit message:
Make vxlan port configurable (see networkservicemesh/sdk#1091)

Signed-off-by: Zoltan Lugossy <zoltan.lugossy@est.tech>
zolug added a commit to Nordix/nsm-sdk-vpp that referenced this pull request Oct 1, 2021
@zolug
Make vxlan port configurable
80cc6e3 
networkservicemesh/sdk commit message:
Make vxlan port configurable (see networkservicemesh/sdk#1091)

Signed-off-by: Zoltan Lugossy <zoltan.lugossy@est.tech>
edwarnicke pushed a commit to networkservicemesh/sdk-vpp that referenced this pull request Oct 6, 2021
@zolug
Make vxlan port configurable (#394)
a3f3e2c 
networkservicemesh/sdk commit message:
Make vxlan port configurable (see networkservicemesh/sdk#1091)

Signed-off-by: Zoltan Lugossy <zoltan.lugossy@est.tech>
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder-vpp that referenced this pull request Oct 6, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8ec6d00 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#394

Commit: a3f3e2c
Author: zolug
Date: 2021-10-06 22:52:48 +0200
Message:
  - Make vxlan port configurable (#394)
networkservicemesh/sdk commit message:
Make vxlan port configurable (see networkservicemesh/sdk#1091)

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-vpp that referenced this pull request Oct 6, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
30d30eb 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#394

Commit: a3f3e2c
Author: zolug
Date: 2021-10-06 22:52:48 +0200
Message:
  - Make vxlan port configurable (#394)
networkservicemesh/sdk commit message:
Make vxlan port configurable (see networkservicemesh/sdk#1091)

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-firewall-vpp that referenced this pull request Oct 6, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9365d30 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#394

Commit: a3f3e2c
Author: zolug
Date: 2021-10-06 22:52:48 +0200
Message:
  - Make vxlan port configurable (#394)
networkservicemesh/sdk commit message:
Make vxlan port configurable (see networkservicemesh/sdk#1091)

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Oct 6, 2021
Merged
Merged
Merged
nsmbot pushed a commit to networkservicemesh/cmd-forwarder-vpp that referenced this pull request Oct 6, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6274944 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#394

Commit: a3f3e2c
Author: zolug
Date: 2021-10-06 22:52:48 +0200
Message:
  - Make vxlan port configurable (#394)
networkservicemesh/sdk commit message:
Make vxlan port configurable (see networkservicemesh/sdk#1091)

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Oct 6, 2021
Merged
zolug added a commit to Nordix/nsm-cmd-forwarder-vpp that referenced this pull request Oct 7, 2021
@zolug
Make vxlan port configurable (networkservicemesh#341)
13b6189 
networkservicemesh/sdk-vpp commit message:
Make vxlan port configurable (see networkservicemesh/sdk-vpp#394)

networkservicemesh/sdk commit message:
Make vxlan port configurable (see networkservicemesh/sdk#1091)

Signed-off-by: Zoltan Lugossy <zoltan.lugossy@est.tech>
zolug added a commit to Nordix/nsm-cmd-forwarder-vpp that referenced this pull request Oct 7, 2021
@zolug
Make vxlan port configurable (networkservicemesh#341)
07fa135 
networkservicemesh/sdk-vpp commit message:
Make vxlan port configurable (see networkservicemesh/sdk-vpp#394)

networkservicemesh/sdk commit message:
Make vxlan port configurable (see networkservicemesh/sdk#1091)

Signed-off-by: Zoltan Lugossy <zoltan.lugossy@est.tech>
edwarnicke pushed a commit to networkservicemesh/cmd-forwarder-vpp that referenced this pull request Oct 7, 2021
@zolug
Make vxlan port configurable (#341) (#352)
d531e5d 
networkservicemesh/sdk-vpp commit message:
Make vxlan port configurable (see networkservicemesh/sdk-vpp#394)

networkservicemesh/sdk commit message:
Make vxlan port configurable (see networkservicemesh/sdk#1091)

Signed-off-by: Zoltan Lugossy <zoltan.lugossy@est.tech>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Oct 7, 2021
Update go.mod and go.sum to latest version from networkservicemesh/cm…
5018610 
…d-forwarder-vpp@main

PR link: https://github.com/networkservicemesh/cmd-forwarder-vpp/pull/

Commit: d531e5d
Author: zolug
Date: 2021-10-07 16:23:45 +0200
Message:
  - Make vxlan port configurable (#341) (#352)
networkservicemesh/sdk-vpp commit message:
Make vxlan port configurable (see networkservicemesh/sdk-vpp#394)

networkservicemesh/sdk commit message:
Make vxlan port configurable (see networkservicemesh/sdk#1091)

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Oct 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwarnicke edwarnicke edwarnicke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zolug @edwarnicke