Add singlepointipam #1093
Merged
Add singlepointipam #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
9 tasks
8 tasks
|
@glazychev-art Could you please review this when you will have time? Thanks. |
| if dstSet { | ||
| return &connectionInfo{ | ||
| ipPool: sipam.ipPools[i], | ||
| srcAddr: srcAddr.String() + sipam.masks[i], |
There was a problem hiding this comment.
do we also need non /32 mask for srcAddr?
There was a problem hiding this comment.
It is meant to be used for external communication also. The client pod which getting this address should be connected to a router and should belong to wider subnet, for example /24.
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Nov 8, 2021
…k@main PR link: networkservicemesh/sdk#1093 Commit: 113a36b Author: Laszlo Kiraly Date: 2021-11-08 22:04:42 +0100 Message: - Add singlepointipam (#1093) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Nov 8, 2021
…k@main PR link: networkservicemesh/sdk#1093 Commit: 113a36b Author: Laszlo Kiraly Date: 2021-11-08 22:04:42 +0100 Message: - Add singlepointipam (#1093) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Nov 8, 2021
…k@main PR link: networkservicemesh/sdk#1093 Commit: 113a36b Author: Laszlo Kiraly Date: 2021-11-08 22:04:42 +0100 Message: - Add singlepointipam (#1093) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Nov 8, 2021
…k@main PR link: networkservicemesh/sdk#1093 Commit: 113a36b Author: Laszlo Kiraly Date: 2021-11-08 22:04:42 +0100 Message: - Add singlepointipam (#1093) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Nov 8, 2021
…k@main PR link: networkservicemesh/sdk#1093 Commit: 113a36b Author: Laszlo Kiraly Date: 2021-11-08 22:04:42 +0100 Message: - Add singlepointipam (#1093) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Nov 8, 2021
…k@main PR link: networkservicemesh/sdk#1093 Commit: 113a36b Author: Laszlo Kiraly Date: 2021-11-08 22:04:42 +0100 Message: - Add singlepointipam (#1093) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Nov 8, 2021
…k@main PR link: networkservicemesh/sdk#1093 Commit: 113a36b Author: Laszlo Kiraly Date: 2021-11-08 22:04:42 +0100 Message: - Add singlepointipam (#1093) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Nov 8, 2021
…k@main PR link: networkservicemesh/sdk#1093 Commit: 113a36b Author: Laszlo Kiraly Date: 2021-11-08 22:04:42 +0100 Message: - Add singlepointipam (#1093) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Nov 8, 2021
…k@main PR link: networkservicemesh/sdk#1093 Commit: 113a36b Author: Laszlo Kiraly Date: 2021-11-08 22:04:42 +0100 Message: - Add singlepointipam (#1093) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Laszlo Kiraly laszlo.kiraly@est.tech
Description
singlepointipam provides an IPAM server chain element. The server provides IPv4/IPv6 addresses from a given address range and updates the IP context with a new destination address, but the source address is generated once.
Issue link
#951
How Has This Been Tested?
Types of changes