-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vxlan] store generated vni in metadata #1117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glazychev-art
changed the title
Store generated vni in metadata
[vxlan] store generated vni in metadata
Oct 25, 2021
edwarnicke
approved these changes
Oct 25, 2021
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
glazychev-art
force-pushed
the
vni_fix
branch
from
October 26, 2021 07:12
72e34c9
to
f5cdfa3
Compare
denis-tingaikin
approved these changes
Oct 26, 2021
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Oct 26, 2021
…k@main PR link: networkservicemesh/sdk#1117 Commit: ace8d38 Author: Artem Glazychev Date: 2021-10-27 02:53:08 +0700 Message: - Store generated vni in metadata (#1117) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Oct 26, 2021
…k@main PR link: networkservicemesh/sdk#1117 Commit: ace8d38 Author: Artem Glazychev Date: 2021-10-27 02:53:08 +0700 Message: - Store generated vni in metadata (#1117) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Oct 26, 2021
…k@main PR link: networkservicemesh/sdk#1117 Commit: ace8d38 Author: Artem Glazychev Date: 2021-10-27 02:53:08 +0700 Message: - Store generated vni in metadata (#1117) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Oct 26, 2021
…k@main PR link: networkservicemesh/sdk#1117 Commit: ace8d38 Author: Artem Glazychev Date: 2021-10-27 02:53:08 +0700 Message: - Store generated vni in metadata (#1117) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Oct 26, 2021
…k@main PR link: networkservicemesh/sdk#1117 Commit: ace8d38 Author: Artem Glazychev Date: 2021-10-27 02:53:08 +0700 Message: - Store generated vni in metadata (#1117) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Oct 26, 2021
…k@main PR link: networkservicemesh/sdk#1117 Commit: ace8d38 Author: Artem Glazychev Date: 2021-10-27 02:53:08 +0700 Message: - Store generated vni in metadata (#1117) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Oct 26, 2021
…k@main PR link: networkservicemesh/sdk#1117 Commit: ace8d38 Author: Artem Glazychev Date: 2021-10-27 02:53:08 +0700 Message: - Store generated vni in metadata (#1117) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Oct 26, 2021
…k@main PR link: networkservicemesh/sdk#1117 Commit: ace8d38 Author: Artem Glazychev Date: 2021-10-27 02:53:08 +0700 Message: - Store generated vni in metadata (#1117) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Oct 26, 2021
Mixaster995
pushed a commit
to Mixaster995/sdk
that referenced
this pull request
Oct 29, 2021
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Glazychev artem.glazychev@xored.com
Description
If we already created
vxlan
interface but in the next request we received mechanism with empty parameters (one of the healing situation) - we will re-generatevni
, which is wrong.How Has This Been Tested?
Types of changes