Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vxlan] store generated vni in metadata #1117

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

glazychev-art
Copy link
Contributor

Signed-off-by: Artem Glazychev artem.glazychev@xored.com

Description

If we already created vxlan interface but in the next request we received mechanism with empty parameters (one of the healing situation) - we will re-generate vni, which is wrong.

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@glazychev-art glazychev-art changed the title Store generated vni in metadata [vxlan] store generated vni in metadata Oct 25, 2021
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@glazychev-art glazychev-art marked this pull request as ready for review October 26, 2021 07:18
@edwarnicke edwarnicke merged commit ace8d38 into networkservicemesh:main Oct 26, 2021
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Oct 26, 2021
…k@main

PR link: networkservicemesh/sdk#1117

Commit: ace8d38
Author: Artem Glazychev
Date: 2021-10-27 02:53:08 +0700
Message:
  - Store generated vni in metadata (#1117)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Oct 26, 2021
…k@main

PR link: networkservicemesh/sdk#1117

Commit: ace8d38
Author: Artem Glazychev
Date: 2021-10-27 02:53:08 +0700
Message:
  - Store generated vni in metadata (#1117)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Oct 26, 2021
…k@main

PR link: networkservicemesh/sdk#1117

Commit: ace8d38
Author: Artem Glazychev
Date: 2021-10-27 02:53:08 +0700
Message:
  - Store generated vni in metadata (#1117)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Oct 26, 2021
…k@main

PR link: networkservicemesh/sdk#1117

Commit: ace8d38
Author: Artem Glazychev
Date: 2021-10-27 02:53:08 +0700
Message:
  - Store generated vni in metadata (#1117)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Oct 26, 2021
…k@main

PR link: networkservicemesh/sdk#1117

Commit: ace8d38
Author: Artem Glazychev
Date: 2021-10-27 02:53:08 +0700
Message:
  - Store generated vni in metadata (#1117)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Oct 26, 2021
…k@main

PR link: networkservicemesh/sdk#1117

Commit: ace8d38
Author: Artem Glazychev
Date: 2021-10-27 02:53:08 +0700
Message:
  - Store generated vni in metadata (#1117)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Oct 26, 2021
…k@main

PR link: networkservicemesh/sdk#1117

Commit: ace8d38
Author: Artem Glazychev
Date: 2021-10-27 02:53:08 +0700
Message:
  - Store generated vni in metadata (#1117)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Oct 26, 2021
…k@main

PR link: networkservicemesh/sdk#1117

Commit: ace8d38
Author: Artem Glazychev
Date: 2021-10-27 02:53:08 +0700
Message:
  - Store generated vni in metadata (#1117)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Mixaster995 pushed a commit to Mixaster995/sdk that referenced this pull request Oct 29, 2021
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants