Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qfix] Delete from clientconn map if dial fails #1155

Merged
merged 1 commit into from
Nov 11, 2021
Merged

[qfix] Delete from clientconn map if dial fails #1155

merged 1 commit into from
Nov 11, 2021

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Nov 11, 2021 •
edited by denis-tingaikin
Loading

Signed-off-by: Artem Glazychev artem.glazychev@xored.com

Motivation

Fixes https://github.com/networkservicemesh/sdk/files/7519966/nsmgr-phjrv-previous.txt

Description

If dial fails we need to delete dialer from metadata

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

denis-tingaikin
denis-tingaikin reviewed Nov 11, 2021
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glazychev-art
[qfix] Delete from clientconn map if dial fails
7d5f6a8 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
denis-tingaikin
denis-tingaikin approved these changes Nov 11, 2021
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edwarnicke we found this issue on CI.

nsmgr-phjrv-previous.txt

So merging

@denis-tingaikin denis-tingaikin merged commit a27b1e7 into networkservicemesh:main Nov 11, 2021
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Nov 11, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8f0b051 
…k@main

PR link: networkservicemesh/sdk#1155

Commit: a27b1e7
Author: Artem Glazychev
Date: 2021-11-11 18:14:30 +0700
Message:
  - [qfix] Delete from clientconn map if dial fails (#1155)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Nov 11, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
27179ba 
…k@main

PR link: networkservicemesh/sdk#1155

Commit: a27b1e7
Author: Artem Glazychev
Date: 2021-11-11 18:14:30 +0700
Message:
  - [qfix] Delete from clientconn map if dial fails (#1155)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Nov 11, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
47c6d99 
…k@main

PR link: networkservicemesh/sdk#1155

Commit: a27b1e7
Author: Artem Glazychev
Date: 2021-11-11 18:14:30 +0700
Message:
  - [qfix] Delete from clientconn map if dial fails (#1155)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Nov 11, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
75b478a 
…k@main

PR link: networkservicemesh/sdk#1155

Commit: a27b1e7
Author: Artem Glazychev
Date: 2021-11-11 18:14:30 +0700
Message:
  - [qfix] Delete from clientconn map if dial fails (#1155)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Nov 11, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
090bf5e 
…k@main

PR link: networkservicemesh/sdk#1155

Commit: a27b1e7
Author: Artem Glazychev
Date: 2021-11-11 18:14:30 +0700
Message:
  - [qfix] Delete from clientconn map if dial fails (#1155)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Nov 11, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b662bc7 
…k@main

PR link: networkservicemesh/sdk#1155

Commit: a27b1e7
Author: Artem Glazychev
Date: 2021-11-11 18:14:30 +0700
Message:
  - [qfix] Delete from clientconn map if dial fails (#1155)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Nov 11, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1c0685b 
…k@main

PR link: networkservicemesh/sdk#1155

Commit: a27b1e7
Author: Artem Glazychev
Date: 2021-11-11 18:14:30 +0700
Message:
  - [qfix] Delete from clientconn map if dial fails (#1155)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Nov 11, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0b4517c 
…k@main

PR link: networkservicemesh/sdk#1155

Commit: a27b1e7
Author: Artem Glazychev
Date: 2021-11-11 18:14:30 +0700
Message:
  - [qfix] Delete from clientconn map if dial fails (#1155)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Nov 11, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b36039d 
…k@main

PR link: networkservicemesh/sdk#1155

Commit: a27b1e7
Author: Artem Glazychev
Date: 2021-11-11 18:14:30 +0700
Message:
  - [qfix] Delete from clientconn map if dial fails (#1155)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 11, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glazychev-art @denis-tingaikin