Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open Telemetry minor fix #1212

Merged
merged 2 commits into from
Jan 13, 2022
Merged

Open Telemetry minor fix #1212

merged 2 commits into from
Jan 13, 2022

Conversation

NikitaSkrynnik
Copy link
Contributor

Signed-off-by: Nikita Skrynnik nikita.skrynnik@xored.com

Description

Issue link

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@NikitaSkrynnik
move IsEnabled func
9c6f7c7 
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
denis-tingaikin
denis-tingaikin requested changes Jan 13, 2022
View reviewed changes
pkg/tools/opentelemetry/opentelemetry.go Outdated Show resolved Hide resolved
pkg/tools/opentelemetry/opentelemetry.go Outdated Show resolved Hide resolved
pkg/tools/opentelemetry/opentelemetry.go Outdated Show resolved Hide resolved
@NikitaSkrynnik
apply suggestions
8272dd4 
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik NikitaSkrynnik marked this pull request as ready for review January 13, 2022 02:56
@denis-tingaikin denis-tingaikin merged commit 5d3e278 into networkservicemesh:main Jan 13, 2022
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Jan 13, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
95a01fa 
…k@main

PR link: networkservicemesh/sdk#1212

Commit: 5d3e278
Author: Nikita Skrynnik
Date: 2022-01-13 14:01:44 +1100
Message:
  - Open Telemetry minor fix (#1212)
* move IsEnabled func

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* apply suggestions

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Jan 13, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2d99412 
…k@main

PR link: networkservicemesh/sdk#1212

Commit: 5d3e278
Author: Nikita Skrynnik
Date: 2022-01-13 14:01:44 +1100
Message:
  - Open Telemetry minor fix (#1212)
* move IsEnabled func

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* apply suggestions

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Jan 13, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
dc8ef26 
…k@main

PR link: networkservicemesh/sdk#1212

Commit: 5d3e278
Author: Nikita Skrynnik
Date: 2022-01-13 14:01:44 +1100
Message:
  - Open Telemetry minor fix (#1212)
* move IsEnabled func

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* apply suggestions

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Jan 13, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
15fc20b 
…k@main

PR link: networkservicemesh/sdk#1212

Commit: 5d3e278
Author: Nikita Skrynnik
Date: 2022-01-13 14:01:44 +1100
Message:
  - Open Telemetry minor fix (#1212)
* move IsEnabled func

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* apply suggestions

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Jan 13, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
254946f 
…k@main

PR link: networkservicemesh/sdk#1212

Commit: 5d3e278
Author: Nikita Skrynnik
Date: 2022-01-13 14:01:44 +1100
Message:
  - Open Telemetry minor fix (#1212)
* move IsEnabled func

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* apply suggestions

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Jan 13, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a24e65e 
…k@main

PR link: networkservicemesh/sdk#1212

Commit: 5d3e278
Author: Nikita Skrynnik
Date: 2022-01-13 14:01:44 +1100
Message:
  - Open Telemetry minor fix (#1212)
* move IsEnabled func

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* apply suggestions

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Jan 13, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a4fe399 
…k@main

PR link: networkservicemesh/sdk#1212

Commit: 5d3e278
Author: Nikita Skrynnik
Date: 2022-01-13 14:01:44 +1100
Message:
  - Open Telemetry minor fix (#1212)
* move IsEnabled func

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* apply suggestions

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Jan 13, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6f9a3f8 
…k@main

PR link: networkservicemesh/sdk#1212

Commit: 5d3e278
Author: Nikita Skrynnik
Date: 2022-01-13 14:01:44 +1100
Message:
  - Open Telemetry minor fix (#1212)
* move IsEnabled func

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* apply suggestions

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Jan 13, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
084009a 
…k@main

PR link: networkservicemesh/sdk#1212

Commit: 5d3e278
Author: Nikita Skrynnik
Date: 2022-01-13 14:01:44 +1100
Message:
  - Open Telemetry minor fix (#1212)
* move IsEnabled func

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* apply suggestions

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Jan 13, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0cda022 
…k@main

PR link: networkservicemesh/sdk#1212

Commit: 5d3e278
Author: Nikita Skrynnik
Date: 2022-01-13 14:01:44 +1100
Message:
  - Open Telemetry minor fix (#1212)
* move IsEnabled func

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* apply suggestions

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Jan 13, 2022
Merged
@NikitaSkrynnik NikitaSkrynnik deleted the fix-opentelemetry branch June 19, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NikitaSkrynnik @denis-tingaikin