Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Test_RefreshNSEClient_SetsCorrectExpireTime #1254

Merged
merged 12 commits into from
Apr 15, 2022
Merged

fix Test_RefreshNSEClient_SetsCorrectExpireTime #1254

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9e43f6a
run test 100 times
NikitaSkrynnik Apr 4, 2022
85e3358
add logs
NikitaSkrynnik Apr 4, 2022
8b19f5e
increase testWait for require.Eventually
NikitaSkrynnik Apr 4, 2022
d411804
run test 300 times
NikitaSkrynnik Apr 4, 2022
4f5ffe6
run test 2000 times
NikitaSkrynnik Apr 4, 2022
287e6ef
run test 1500 times
NikitaSkrynnik Apr 4, 2022
b291988
run test 1000 times
NikitaSkrynnik Apr 4, 2022
5bb9053
run test 10000 times
NikitaSkrynnik Apr 6, 2022
c2630bf
increase testWait
NikitaSkrynnik Apr 6, 2022
cd6a78d
cleanup
NikitaSkrynnik Apr 7, 2022
6b49c23
run test 100000 times
NikitaSkrynnik Apr 7, 2022
a0c7d2b
cleanup
NikitaSkrynnik Apr 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/registry/common/refresh/nse_registry_client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ func Test_RefreshNSEClient_SetsCorrectExpireTime(t *testing.T) {
clockMock.Add(expireTimeout / 3 * 2)
require.Eventually(t, func() bool {
return atomic.LoadInt32(&countClient.requestCount) > count
}, testWait, testTick)
}, 4*testWait, testTick)

// Wait for the Refresh to fully happen
time.Sleep(testWait)
Expand Down