Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable trace logging only if logrus.LogLevel() is TRACE #1273

Merged
merged 1 commit into from
Apr 27, 2022
Merged

fix: enable trace logging only if logrus.LogLevel() is TRACE #1273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/tools/log/logger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ package log
import (
"context"
"sync/atomic"

"github.com/sirupsen/logrus"
)

type contextKeyType string
Expand Down Expand Up @@ -77,7 +79,8 @@ func WithLog(ctx context.Context, log ...Logger) context.Context {

// IsTracingEnabled - checks if it is allowed to use traces
func IsTracingEnabled() bool {
return atomic.LoadInt32(&isTracingEnabled) != 0
// TODO: Rework this within https://github.com/networkservicemesh/sdk/issues/1272
return atomic.LoadInt32(&isTracingEnabled) != 0 && logrus.GetLevel() == logrus.TraceLevel
}

// EnableTracing - enable/disable traces
Expand Down