Make local spire more configurable #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
pkg/tools/spire/options.go
Outdated
| @@ -49,11 +53,33 @@ func WithAgentID(agentID string) Option { | |||
| } | |||
|
|
|||
| // WithEntry - Option to add Entry to spire-server. May be used multiple times. | |||
| func WithEntry(spiffeID, selector string) Option { | |||
| func WithEntry(spiffeID, selector, federatesWith string) Option { | |||
There was a problem hiding this comment.
This could break all cmd apps. Please consider about adding a new option WitthFederatesEntry or something like that
| func AddEntry(ctx context.Context, parentID, spiffeID, selector string) error { | ||
| cmdStr := "spire-server entry create -parentID %s -spiffeID %s -selector %s -socketPath %s/api.sock" | ||
| cmdStr = fmt.Sprintf(cmdStr, parentID, spiffeID, selector, spireRoot) | ||
| func AddEntry(ctx context.Context, parentID, spiffeID, selector, federatesWith string) error { |
There was a problem hiding this comment.
Is it using by docker tests in current apps?
There was a problem hiding this comment.
Yes it is used
There was a problem hiding this comment.
Should we save backward compativlity?
There was a problem hiding this comment.
I misunderstood you. AddEntry - is not used directly in apps. Currently, we only use WithEntry option for this purpose.
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
denis-tingaikin
approved these changes
May 6, 2022
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
May 6, 2022
…k@main PR link: networkservicemesh/sdk#1274 Commit: 3a426c3 Author: Artem Glazychev Date: 2022-05-06 21:16:07 +0700 Message: - Make local spire more configurable (#1274) * Make local spire more configurable Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add federated entry separately Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
May 6, 2022
…k@main PR link: networkservicemesh/sdk#1274 Commit: 3a426c3 Author: Artem Glazychev Date: 2022-05-06 21:16:07 +0700 Message: - Make local spire more configurable (#1274) * Make local spire more configurable Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add federated entry separately Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
May 6, 2022
…k@main PR link: networkservicemesh/sdk#1274 Commit: 3a426c3 Author: Artem Glazychev Date: 2022-05-06 21:16:07 +0700 Message: - Make local spire more configurable (#1274) * Make local spire more configurable Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add federated entry separately Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
May 6, 2022
…k@main PR link: networkservicemesh/sdk#1274 Commit: 3a426c3 Author: Artem Glazychev Date: 2022-05-06 21:16:07 +0700 Message: - Make local spire more configurable (#1274) * Make local spire more configurable Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add federated entry separately Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
May 6, 2022
…k@main PR link: networkservicemesh/sdk#1274 Commit: 3a426c3 Author: Artem Glazychev Date: 2022-05-06 21:16:07 +0700 Message: - Make local spire more configurable (#1274) * Make local spire more configurable Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add federated entry separately Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
May 6, 2022
…k@main PR link: networkservicemesh/sdk#1274 Commit: 3a426c3 Author: Artem Glazychev Date: 2022-05-06 21:16:07 +0700 Message: - Make local spire more configurable (#1274) * Make local spire more configurable Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add federated entry separately Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
May 6, 2022
…k@main PR link: networkservicemesh/sdk#1274 Commit: 3a426c3 Author: Artem Glazychev Date: 2022-05-06 21:16:07 +0700 Message: - Make local spire more configurable (#1274) * Make local spire more configurable Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add federated entry separately Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
May 6, 2022
…k@main PR link: networkservicemesh/sdk#1274 Commit: 3a426c3 Author: Artem Glazychev Date: 2022-05-06 21:16:07 +0700 Message: - Make local spire more configurable (#1274) * Make local spire more configurable Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add federated entry separately Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
May 6, 2022
…k@main PR link: networkservicemesh/sdk#1274 Commit: 3a426c3 Author: Artem Glazychev Date: 2022-05-06 21:16:07 +0700 Message: - Make local spire more configurable (#1274) * Make local spire more configurable Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add federated entry separately Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
May 6, 2022
…k@main PR link: networkservicemesh/sdk#1274 Commit: 3a426c3 Author: Artem Glazychev Date: 2022-05-06 21:16:07 +0700 Message: - Make local spire more configurable (#1274) * Make local spire more configurable Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add federated entry separately Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
May 6, 2022
…k@main PR link: networkservicemesh/sdk#1274 Commit: 3a426c3 Author: Artem Glazychev Date: 2022-05-06 21:16:07 +0700 Message: - Make local spire more configurable (#1274) * Make local spire more configurable Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add federated entry separately Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
May 6, 2022
…k@main PR link: networkservicemesh/sdk#1274 Commit: 3a426c3 Author: Artem Glazychev Date: 2022-05-06 21:16:07 +0700 Message: - Make local spire more configurable (#1274) * Make local spire more configurable Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Add federated entry separately Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Glazychev artem.glazychev@xored.com
Description
With this PR we can customize the spire configuration.
Main things that have been added:
Issue link
networkservicemesh/cmd-nse-simple-vl3-docker#1
How Has This Been Tested?
Types of changes