Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qfix: remove extra registry lookup for the inter-domain network service resolve #1279

Merged
merged 1 commit into from
May 7, 2022
Merged

qfix: remove extra registry lookup for the inter-domain network service resolve #1279

merged 1 commit into from
May 7, 2022

Conversation

denis-tingaikin
Copy link
Member

@denis-tingaikin denis-tingaikin commented May 6, 2022 •
edited
Loading

Signed-off-by: Denis Tingaikin denis.tingajkin@xored.com

Description

This PR fixes problem with translating interdomain queries from the remote site to the local.
It is also fixes vl3 + interdomain cases, because we are selecing fib table based on the service name.

As an additional benifit it also removes extra registry lookup for the inter-domain network service resolve

Issue link

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@denis-tingaikin
qfix: remove extra registry lookup for the inter-domain network servi…
3d75ca8 
…ce resolve

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
@denis-tingaikin denis-tingaikin requested a review from edwarnicke May 6, 2022 23:55
@denis-tingaikin
Copy link
Member Author

@edwarnicke Could you review this one?

@edwarnicke edwarnicke merged commit 41196bd into networkservicemesh:main May 7, 2022
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request May 7, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8cb4606 
…k@main

PR link: networkservicemesh/sdk#1279

Commit: 41196bd
Author: Denis Tingaikin
Date: 2022-05-07 20:38:09 +0300
Message:
  - qfix: remove extra registry lookup for the inter-domain network service resolve (#1279)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request May 7, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c0e1bf1 
…k@main

PR link: networkservicemesh/sdk#1279

Commit: 41196bd
Author: Denis Tingaikin
Date: 2022-05-07 20:38:09 +0300
Message:
  - qfix: remove extra registry lookup for the inter-domain network service resolve (#1279)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request May 7, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
5666929 
…k@main

PR link: networkservicemesh/sdk#1279

Commit: 41196bd
Author: Denis Tingaikin
Date: 2022-05-07 20:38:09 +0300
Message:
  - qfix: remove extra registry lookup for the inter-domain network service resolve (#1279)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request May 7, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d029f9b 
…k@main

PR link: networkservicemesh/sdk#1279

Commit: 41196bd
Author: Denis Tingaikin
Date: 2022-05-07 20:38:09 +0300
Message:
  - qfix: remove extra registry lookup for the inter-domain network service resolve (#1279)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request May 7, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2758a99 
…k@main

PR link: networkservicemesh/sdk#1279

Commit: 41196bd
Author: Denis Tingaikin
Date: 2022-05-07 20:38:09 +0300
Message:
  - qfix: remove extra registry lookup for the inter-domain network service resolve (#1279)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request May 7, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9ac0d59 
…k@main

PR link: networkservicemesh/sdk#1279

Commit: 41196bd
Author: Denis Tingaikin
Date: 2022-05-07 20:38:09 +0300
Message:
  - qfix: remove extra registry lookup for the inter-domain network service resolve (#1279)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request May 7, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
01e629d 
…k@main

PR link: networkservicemesh/sdk#1279

Commit: 41196bd
Author: Denis Tingaikin
Date: 2022-05-07 20:38:09 +0300
Message:
  - qfix: remove extra registry lookup for the inter-domain network service resolve (#1279)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request May 7, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
259d5e9 
…k@main

PR link: networkservicemesh/sdk#1279

Commit: 41196bd
Author: Denis Tingaikin
Date: 2022-05-07 20:38:09 +0300
Message:
  - qfix: remove extra registry lookup for the inter-domain network service resolve (#1279)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request May 7, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
af6004f 
…k@main

PR link: networkservicemesh/sdk#1279

Commit: 41196bd
Author: Denis Tingaikin
Date: 2022-05-07 20:38:09 +0300
Message:
  - qfix: remove extra registry lookup for the inter-domain network service resolve (#1279)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request May 7, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
331372f 
…k@main

PR link: networkservicemesh/sdk#1279

Commit: 41196bd
Author: Denis Tingaikin
Date: 2022-05-07 20:38:09 +0300
Message:
  - qfix: remove extra registry lookup for the inter-domain network service resolve (#1279)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request May 7, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
7abe5ef 
…k@main

PR link: networkservicemesh/sdk#1279

Commit: 41196bd
Author: Denis Tingaikin
Date: 2022-05-07 20:38:09 +0300
Message:
  - qfix: remove extra registry lookup for the inter-domain network service resolve (#1279)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request May 7, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
89dbf96 
…k@main

PR link: networkservicemesh/sdk#1279

Commit: 41196bd
Author: Denis Tingaikin
Date: 2022-05-07 20:38:09 +0300
Message:
  - qfix: remove extra registry lookup for the inter-domain network service resolve (#1279)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced May 7, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwarnicke edwarnicke Awaiting requested review from edwarnicke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denis-tingaikin @edwarnicke