-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qfix: restore default resolv.conf file on application restarting/stopping #1288
Merged
edwarnicke
merged 1 commit into
networkservicemesh:main
from
denis-tingaikin:fix-nsm-dns-restart-case
May 13, 2022
Merged
qfix: restore default resolv.conf file on application restarting/stopping #1288
edwarnicke
merged 1 commit into
networkservicemesh:main
from
denis-tingaikin:fix-nsm-dns-restart-case
May 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
changed the title
qfix: restore default resolv.conf file on restarting/stopping
qfix: restore default resolv.conf file on application restarting/stopping
May 13, 2022
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
May 13, 2022
…k@main PR link: networkservicemesh/sdk#1288 Commit: b9a2a4e Author: Denis Tingaikin Date: 2022-05-14 02:04:45 +0300 Message: - add restore default resolv.conf file (#1288) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
May 13, 2022
…k@main PR link: networkservicemesh/sdk#1288 Commit: b9a2a4e Author: Denis Tingaikin Date: 2022-05-14 02:04:45 +0300 Message: - add restore default resolv.conf file (#1288) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
May 13, 2022
…k@main PR link: networkservicemesh/sdk#1288 Commit: b9a2a4e Author: Denis Tingaikin Date: 2022-05-14 02:04:45 +0300 Message: - add restore default resolv.conf file (#1288) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
May 13, 2022
…k@main PR link: networkservicemesh/sdk#1288 Commit: b9a2a4e Author: Denis Tingaikin Date: 2022-05-14 02:04:45 +0300 Message: - add restore default resolv.conf file (#1288) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
May 13, 2022
…k@main PR link: networkservicemesh/sdk#1288 Commit: b9a2a4e Author: Denis Tingaikin Date: 2022-05-14 02:04:45 +0300 Message: - add restore default resolv.conf file (#1288) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
May 13, 2022
…k@main PR link: networkservicemesh/sdk#1288 Commit: b9a2a4e Author: Denis Tingaikin Date: 2022-05-14 02:04:45 +0300 Message: - add restore default resolv.conf file (#1288) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
May 13, 2022
…k@main PR link: networkservicemesh/sdk#1288 Commit: b9a2a4e Author: Denis Tingaikin Date: 2022-05-14 02:04:45 +0300 Message: - add restore default resolv.conf file (#1288) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
May 13, 2022
…k@main PR link: networkservicemesh/sdk#1288 Commit: b9a2a4e Author: Denis Tingaikin Date: 2022-05-14 02:04:45 +0300 Message: - add restore default resolv.conf file (#1288) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
May 13, 2022
…k@main PR link: networkservicemesh/sdk#1288 Commit: b9a2a4e Author: Denis Tingaikin Date: 2022-05-14 02:04:45 +0300 Message: - add restore default resolv.conf file (#1288) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
May 13, 2022
…k@main PR link: networkservicemesh/sdk#1288 Commit: b9a2a4e Author: Denis Tingaikin Date: 2022-05-14 02:04:45 +0300 Message: - add restore default resolv.conf file (#1288) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
May 13, 2022
…k@main PR link: networkservicemesh/sdk#1288 Commit: b9a2a4e Author: Denis Tingaikin Date: 2022-05-14 02:04:45 +0300 Message: - add restore default resolv.conf file (#1288) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
May 13, 2022
…k@main PR link: networkservicemesh/sdk#1288 Commit: b9a2a4e Author: Denis Tingaikin Date: 2022-05-14 02:04:45 +0300 Message: - add restore default resolv.conf file (#1288) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Denis Tingaikin denis.tingajkin@xored.com
Description
Fixes the problem when client is triying to fanout DNS to itself and falling to the loop!
Scenarious:
Scenario 1:
Expected: we dont lost resolv.conf entries
Scenario 1:
Expected: we dont lost resolv.conf entries
Issue link
networkservicemesh/cmd-nse-l7-proxy#4
How Has This Been Tested?
Types of changes