Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qfix: restore default resolv.conf file on application restarting/stopping #1288

Merged

Conversation

denis-tingaikin
Copy link
Member

@denis-tingaikin denis-tingaikin commented May 13, 2022

Signed-off-by: Denis Tingaikin denis.tingajkin@xored.com

Description

Fixes the problem when client is triying to fanout DNS to itself and falling to the loop!

Scenarious:

Scenario 1:

  1. nsc POD restarted

Expected: we dont lost resolv.conf entries

Scenario 1:

  1. nsc-init started
  2. nsc-init-done
  3. nsc started

Expected: we dont lost resolv.conf entries

Issue link

networkservicemesh/cmd-nse-l7-proxy#4

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
@denis-tingaikin denis-tingaikin changed the title qfix: restore default resolv.conf file on restarting/stopping qfix: restore default resolv.conf file on application restarting/stopping May 13, 2022
@edwarnicke edwarnicke merged commit b9a2a4e into networkservicemesh:main May 13, 2022
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request May 13, 2022
…k@main

PR link: networkservicemesh/sdk#1288

Commit: b9a2a4e
Author: Denis Tingaikin
Date: 2022-05-14 02:04:45 +0300
Message:
  - add restore default resolv.conf file (#1288)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request May 13, 2022
…k@main

PR link: networkservicemesh/sdk#1288

Commit: b9a2a4e
Author: Denis Tingaikin
Date: 2022-05-14 02:04:45 +0300
Message:
  - add restore default resolv.conf file (#1288)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request May 13, 2022
…k@main

PR link: networkservicemesh/sdk#1288

Commit: b9a2a4e
Author: Denis Tingaikin
Date: 2022-05-14 02:04:45 +0300
Message:
  - add restore default resolv.conf file (#1288)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request May 13, 2022
…k@main

PR link: networkservicemesh/sdk#1288

Commit: b9a2a4e
Author: Denis Tingaikin
Date: 2022-05-14 02:04:45 +0300
Message:
  - add restore default resolv.conf file (#1288)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request May 13, 2022
…k@main

PR link: networkservicemesh/sdk#1288

Commit: b9a2a4e
Author: Denis Tingaikin
Date: 2022-05-14 02:04:45 +0300
Message:
  - add restore default resolv.conf file (#1288)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request May 13, 2022
…k@main

PR link: networkservicemesh/sdk#1288

Commit: b9a2a4e
Author: Denis Tingaikin
Date: 2022-05-14 02:04:45 +0300
Message:
  - add restore default resolv.conf file (#1288)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request May 13, 2022
…k@main

PR link: networkservicemesh/sdk#1288

Commit: b9a2a4e
Author: Denis Tingaikin
Date: 2022-05-14 02:04:45 +0300
Message:
  - add restore default resolv.conf file (#1288)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request May 13, 2022
…k@main

PR link: networkservicemesh/sdk#1288

Commit: b9a2a4e
Author: Denis Tingaikin
Date: 2022-05-14 02:04:45 +0300
Message:
  - add restore default resolv.conf file (#1288)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request May 13, 2022
…k@main

PR link: networkservicemesh/sdk#1288

Commit: b9a2a4e
Author: Denis Tingaikin
Date: 2022-05-14 02:04:45 +0300
Message:
  - add restore default resolv.conf file (#1288)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request May 13, 2022
…k@main

PR link: networkservicemesh/sdk#1288

Commit: b9a2a4e
Author: Denis Tingaikin
Date: 2022-05-14 02:04:45 +0300
Message:
  - add restore default resolv.conf file (#1288)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request May 13, 2022
…k@main

PR link: networkservicemesh/sdk#1288

Commit: b9a2a4e
Author: Denis Tingaikin
Date: 2022-05-14 02:04:45 +0300
Message:
  - add restore default resolv.conf file (#1288)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request May 13, 2022
…k@main

PR link: networkservicemesh/sdk#1288

Commit: b9a2a4e
Author: Denis Tingaikin
Date: 2022-05-14 02:04:45 +0300
Message:
  - add restore default resolv.conf file (#1288)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants