Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clientinfo chain element #1293

Merged

Conversation

NikitaSkrynnik
Copy link
Contributor

Signed-off-by: Nikita Skrynnik nikita.skrynnik@xored.com

Description

Issue link

#1290

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@NikitaSkrynnik NikitaSkrynnik marked this pull request as draft May 16, 2022 13:16
@NikitaSkrynnik NikitaSkrynnik force-pushed the clientinfo-server branch 3 times, most recently from 76cd416 to 4f34dec Compare May 16, 2022 13:18
@NikitaSkrynnik NikitaSkrynnik marked this pull request as ready for review May 16, 2022 13:36
@NikitaSkrynnik NikitaSkrynnik changed the title Add clientinfo server chain element Add clientinfo chain element May 16, 2022
@NikitaSkrynnik NikitaSkrynnik force-pushed the clientinfo-server branch 2 times, most recently from c917acf to 528ac91 Compare May 17, 2022 09:43
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

techincally looks OK.
Added style-related comments.

"podName": "BBB",
"clusterName": "CCC",
},
var tests = []struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var tests = []struct {
var testCases = []struct {

@@ -0,0 +1,58 @@
// Copyright (c) 2022 Doc.ai and/or its affiliates.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright (c) 2022 Doc.ai and/or its affiliates.
// Copyright (c) 2022 Cisco and/or its affiliates.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct copyright holder for other files

Comment on lines 1 to 4
// Copyright (c) 2021-2022 Doc.ai and/or its affiliates.
//
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright (c) 2021-2022 Doc.ai and/or its affiliates.
//
// Copyright (c) 2021 Doc.ai and/or its affiliates.
//
// Copyright (c) 2022 Cisco and/or its affiliates.

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
@denis-tingaikin denis-tingaikin merged commit 5b89612 into networkservicemesh:main May 23, 2022
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request May 23, 2022
…k@main

PR link: networkservicemesh/sdk#1293

Commit: 5b89612
Author: Nikita Skrynnik
Date: 2022-05-23 17:53:13 +0700
Message:
  - Add clientinfo chain element (#1293)
* add clientinfo server

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* cleanup

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix ci

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix clientinfo client

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix linter

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* launch ci

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* reduce unit test size

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* apply suggestions

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* wake up github actions

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request May 23, 2022
…k@main

PR link: networkservicemesh/sdk#1293

Commit: 5b89612
Author: Nikita Skrynnik
Date: 2022-05-23 17:53:13 +0700
Message:
  - Add clientinfo chain element (#1293)
* add clientinfo server

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* cleanup

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix ci

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix clientinfo client

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix linter

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* launch ci

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* reduce unit test size

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* apply suggestions

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* wake up github actions

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request May 23, 2022
…k@main

PR link: networkservicemesh/sdk#1293

Commit: 5b89612
Author: Nikita Skrynnik
Date: 2022-05-23 17:53:13 +0700
Message:
  - Add clientinfo chain element (#1293)
* add clientinfo server

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* cleanup

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix ci

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix clientinfo client

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix linter

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* launch ci

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* reduce unit test size

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* apply suggestions

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* wake up github actions

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request May 23, 2022
…k@main

PR link: networkservicemesh/sdk#1293

Commit: 5b89612
Author: Nikita Skrynnik
Date: 2022-05-23 17:53:13 +0700
Message:
  - Add clientinfo chain element (#1293)
* add clientinfo server

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* cleanup

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix ci

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix clientinfo client

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix linter

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* launch ci

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* reduce unit test size

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* apply suggestions

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* wake up github actions

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request May 23, 2022
…k@main

PR link: networkservicemesh/sdk#1293

Commit: 5b89612
Author: Nikita Skrynnik
Date: 2022-05-23 17:53:13 +0700
Message:
  - Add clientinfo chain element (#1293)
* add clientinfo server

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* cleanup

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix ci

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix clientinfo client

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix linter

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* launch ci

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* reduce unit test size

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* apply suggestions

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* wake up github actions

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request May 23, 2022
…k@main

PR link: networkservicemesh/sdk#1293

Commit: 5b89612
Author: Nikita Skrynnik
Date: 2022-05-23 17:53:13 +0700
Message:
  - Add clientinfo chain element (#1293)
* add clientinfo server

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* cleanup

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix ci

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix clientinfo client

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix linter

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* launch ci

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* reduce unit test size

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* apply suggestions

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* wake up github actions

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request May 23, 2022
…k@main

PR link: networkservicemesh/sdk#1293

Commit: 5b89612
Author: Nikita Skrynnik
Date: 2022-05-23 17:53:13 +0700
Message:
  - Add clientinfo chain element (#1293)
* add clientinfo server

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* cleanup

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix ci

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix clientinfo client

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix linter

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* launch ci

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* reduce unit test size

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* apply suggestions

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* wake up github actions

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request May 23, 2022
…k@main

PR link: networkservicemesh/sdk#1293

Commit: 5b89612
Author: Nikita Skrynnik
Date: 2022-05-23 17:53:13 +0700
Message:
  - Add clientinfo chain element (#1293)
* add clientinfo server

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* cleanup

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix ci

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix clientinfo client

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix linter

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* launch ci

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* reduce unit test size

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* apply suggestions

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* wake up github actions

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request May 23, 2022
…k@main

PR link: networkservicemesh/sdk#1293

Commit: 5b89612
Author: Nikita Skrynnik
Date: 2022-05-23 17:53:13 +0700
Message:
  - Add clientinfo chain element (#1293)
* add clientinfo server

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* cleanup

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix ci

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix clientinfo client

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix linter

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* launch ci

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* reduce unit test size

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* apply suggestions

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* wake up github actions

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request May 23, 2022
…k@main

PR link: networkservicemesh/sdk#1293

Commit: 5b89612
Author: Nikita Skrynnik
Date: 2022-05-23 17:53:13 +0700
Message:
  - Add clientinfo chain element (#1293)
* add clientinfo server

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* cleanup

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix ci

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix clientinfo client

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix linter

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* launch ci

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* reduce unit test size

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* apply suggestions

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* wake up github actions

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request May 23, 2022
…k@main

PR link: networkservicemesh/sdk#1293

Commit: 5b89612
Author: Nikita Skrynnik
Date: 2022-05-23 17:53:13 +0700
Message:
  - Add clientinfo chain element (#1293)
* add clientinfo server

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* cleanup

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix ci

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix clientinfo client

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix linter

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* launch ci

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* reduce unit test size

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* apply suggestions

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* wake up github actions

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request May 23, 2022
…k@main

PR link: networkservicemesh/sdk#1293

Commit: 5b89612
Author: Nikita Skrynnik
Date: 2022-05-23 17:53:13 +0700
Message:
  - Add clientinfo chain element (#1293)
* add clientinfo server

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* cleanup

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix ci

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix clientinfo client

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix linter

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* launch ci

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* reduce unit test size

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* apply suggestions

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* wake up github actions

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@NikitaSkrynnik NikitaSkrynnik deleted the clientinfo-server branch June 19, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants