Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metrics concurrency #1312

Merged
merged 3 commits into from
Jun 16, 2022
Merged

Fix metrics concurrency #1312

merged 3 commits into from
Jun 16, 2022

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Jun 16, 2022 •
edited
Loading

Signed-off-by: Artem Glazychev artem.glazychev@xored.com

Description

The metrics map should be unique for each connection and shouldn't cause concurrency issues.
In this PR the map has been moved from the chain element to the metadata.

Issue link

Closes: #1311

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@glazychev-art
Fix metrics concurrency
0ae9660 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
denis-tingaikin
denis-tingaikin reviewed Jun 16, 2022
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we somehow cover the problem by unit test?

@glazychev-art
Add unit test
eac9cc9 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
denis-tingaikin
denis-tingaikin approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good,
I have one comment related to new type metricsMap.

@glazychev-art
fix type alias
b7ab950 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@denis-tingaikin denis-tingaikin merged commit 1bc5125 into networkservicemesh:main Jun 16, 2022
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Jun 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
30591b5 
…k@main

PR link: networkservicemesh/sdk#1312

Commit: 1bc5125
Author: Artem Glazychev
Date: 2022-06-16 18:49:33 +0700
Message:
  - Fix metrics concurrency (#1312)
* Fix metrics concurrency

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Add unit test

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* fix type alias

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Jun 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
4201242 
…k@main

PR link: networkservicemesh/sdk#1312

Commit: 1bc5125
Author: Artem Glazychev
Date: 2022-06-16 18:49:33 +0700
Message:
  - Fix metrics concurrency (#1312)
* Fix metrics concurrency

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Add unit test

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* fix type alias

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Jun 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9bd8c0b 
…k@main

PR link: networkservicemesh/sdk#1312

Commit: 1bc5125
Author: Artem Glazychev
Date: 2022-06-16 18:49:33 +0700
Message:
  - Fix metrics concurrency (#1312)
* Fix metrics concurrency

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Add unit test

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* fix type alias

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Jun 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
12f4e79 
…k@main

PR link: networkservicemesh/sdk#1312

Commit: 1bc5125
Author: Artem Glazychev
Date: 2022-06-16 18:49:33 +0700
Message:
  - Fix metrics concurrency (#1312)
* Fix metrics concurrency

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Add unit test

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* fix type alias

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Jun 16, 2022
Merged
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Jun 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
524c239 
…k@main

PR link: networkservicemesh/sdk#1312

Commit: 1bc5125
Author: Artem Glazychev
Date: 2022-06-16 18:49:33 +0700
Message:
  - Fix metrics concurrency (#1312)
* Fix metrics concurrency

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Add unit test

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* fix type alias

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Jun 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
cb11d0e 
…k@main

PR link: networkservicemesh/sdk#1312

Commit: 1bc5125
Author: Artem Glazychev
Date: 2022-06-16 18:49:33 +0700
Message:
  - Fix metrics concurrency (#1312)
* Fix metrics concurrency

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Add unit test

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* fix type alias

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Jun 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9447b44 
…k@main

PR link: networkservicemesh/sdk#1312

Commit: 1bc5125
Author: Artem Glazychev
Date: 2022-06-16 18:49:33 +0700
Message:
  - Fix metrics concurrency (#1312)
* Fix metrics concurrency

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Add unit test

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* fix type alias

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Jun 16, 2022
Merged
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Jun 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
3b56ef4 
…k@main

PR link: networkservicemesh/sdk#1312

Commit: 1bc5125
Author: Artem Glazychev
Date: 2022-06-16 18:49:33 +0700
Message:
  - Fix metrics concurrency (#1312)
* Fix metrics concurrency

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Add unit test

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* fix type alias

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Jun 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
710e0ac 
…k@main

PR link: networkservicemesh/sdk#1312

Commit: 1bc5125
Author: Artem Glazychev
Date: 2022-06-16 18:49:33 +0700
Message:
  - Fix metrics concurrency (#1312)
* Fix metrics concurrency

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Add unit test

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* fix type alias

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Jun 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
36a852b 
…k@main

PR link: networkservicemesh/sdk#1312

Commit: 1bc5125
Author: Artem Glazychev
Date: 2022-06-16 18:49:33 +0700
Message:
  - Fix metrics concurrency (#1312)
* Fix metrics concurrency

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Add unit test

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* fix type alias

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Jun 16, 2022
Merged
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Jun 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
e628c96 
…k@main

PR link: networkservicemesh/sdk#1312

Commit: 1bc5125
Author: Artem Glazychev
Date: 2022-06-16 18:49:33 +0700
Message:
  - Fix metrics concurrency (#1312)
* Fix metrics concurrency

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Add unit test

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* fix type alias

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Jun 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f3fb4d9 
…k@main

PR link: networkservicemesh/sdk#1312

Commit: 1bc5125
Author: Artem Glazychev
Date: 2022-06-16 18:49:33 +0700
Message:
  - Fix metrics concurrency (#1312)
* Fix metrics concurrency

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* Add unit test

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* fix type alias

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jun 16, 2022
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Concurrency issue causing the NSMgr to crash
2 participants
@glazychev-art @denis-tingaikin