Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split swapIP into client and server #1314

Merged

Conversation

glazychev-art
Copy link
Contributor

Signed-off-by: Artem Glazychev artem.glazychev@xored.com

Description

Split swapIP into client and server chain elements

Issue link

Issue: networkservicemesh/cmd-nsc-simple-docker#1

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glazychev-art glazychev-art requested a review from edwarnicke June 27, 2022 10:33
@denis-tingaikin denis-tingaikin merged commit a8211c5 into networkservicemesh:main Jun 29, 2022
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Jun 29, 2022
…k@main

PR link: networkservicemesh/sdk#1314

Commit: a8211c5
Author: Artem Glazychev
Date: 2022-06-29 17:01:33 +0700
Message:
  - Split swapIP into client and server (#1314)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Jun 29, 2022
…k@main

PR link: networkservicemesh/sdk#1314

Commit: a8211c5
Author: Artem Glazychev
Date: 2022-06-29 17:01:33 +0700
Message:
  - Split swapIP into client and server (#1314)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Jun 29, 2022
…k@main

PR link: networkservicemesh/sdk#1314

Commit: a8211c5
Author: Artem Glazychev
Date: 2022-06-29 17:01:33 +0700
Message:
  - Split swapIP into client and server (#1314)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Jun 29, 2022
…k@main

PR link: networkservicemesh/sdk#1314

Commit: a8211c5
Author: Artem Glazychev
Date: 2022-06-29 17:01:33 +0700
Message:
  - Split swapIP into client and server (#1314)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Jun 29, 2022
…k@main

PR link: networkservicemesh/sdk#1314

Commit: a8211c5
Author: Artem Glazychev
Date: 2022-06-29 17:01:33 +0700
Message:
  - Split swapIP into client and server (#1314)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Jun 29, 2022
…k@main

PR link: networkservicemesh/sdk#1314

Commit: a8211c5
Author: Artem Glazychev
Date: 2022-06-29 17:01:33 +0700
Message:
  - Split swapIP into client and server (#1314)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Jun 29, 2022
…k@main

PR link: networkservicemesh/sdk#1314

Commit: a8211c5
Author: Artem Glazychev
Date: 2022-06-29 17:01:33 +0700
Message:
  - Split swapIP into client and server (#1314)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Jun 29, 2022
…k@main

PR link: networkservicemesh/sdk#1314

Commit: a8211c5
Author: Artem Glazychev
Date: 2022-06-29 17:01:33 +0700
Message:
  - Split swapIP into client and server (#1314)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Jun 29, 2022
…k@main

PR link: networkservicemesh/sdk#1314

Commit: a8211c5
Author: Artem Glazychev
Date: 2022-06-29 17:01:33 +0700
Message:
  - Split swapIP into client and server (#1314)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Jun 29, 2022
…k@main

PR link: networkservicemesh/sdk#1314

Commit: a8211c5
Author: Artem Glazychev
Date: 2022-06-29 17:01:33 +0700
Message:
  - Split swapIP into client and server (#1314)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Jun 29, 2022
…k@main

PR link: networkservicemesh/sdk#1314

Commit: a8211c5
Author: Artem Glazychev
Date: 2022-06-29 17:01:33 +0700
Message:
  - Split swapIP into client and server (#1314)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Jun 29, 2022
…k@main

PR link: networkservicemesh/sdk#1314

Commit: a8211c5
Author: Artem Glazychev
Date: 2022-06-29 17:01:33 +0700
Message:
  - Split swapIP into client and server (#1314)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants