-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tracing and logs to dns handlers #1337
Closed
NikitaSkrynnik
wants to merge
12
commits into
networkservicemesh:main
from
NikitaSkrynnik:add-dns-logs
Closed
Add tracing and logs to dns handlers #1337
NikitaSkrynnik
wants to merge
12
commits into
networkservicemesh:main
from
NikitaSkrynnik:add-dns-logs
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
NikitaSkrynnik
changed the title
[qfix] Add logs to dns context functions
Add tracing and logs to dns handlers
Aug 8, 2022
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
pkg/tools/dnsutils/trace/context.go
Outdated
panic("cannot create context from nil parent") | ||
} | ||
|
||
parent = grpcutils.PassTraceToOutgoing(parent) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we don't need this for dns
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
denis-tingaikin
approved these changes
Aug 22, 2022
@glazychev-art Could you also have a look? |
glazychev-art
approved these changes
Aug 22, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nikita Skrynnik nikita.skrynnik@xored.com
Description
Issue link
How Has This Been Tested?
Types of changes