Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove metadata from dnsContextClient #1340

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Remove metadata from dnsContextClient #1340

merged 1 commit into from
Aug 16, 2022

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Aug 15, 2022 •
edited
Loading

Signed-off-by: Artem Glazychev artem.glazychev@xored.com

Description

We cannot use metadata this way, because, if the connection is down (healing case) we first call Close, which will remove the metadata, and then re-Request. And in the new Request, we will add the resolvconfDNSConfig again (because there is nothing in the metadata)

Issue link

networkservicemesh/deployments-k8s#7055

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@glazychev-art
Remove metadata from dnsContextClient
ea52546 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@glazychev-art glazychev-art force-pushed the dns_ctx_client_metadata branch from e41fad2 to ea52546 Compare August 15, 2022 13:42
@denis-tingaikin denis-tingaikin merged commit 67e508c into networkservicemesh:main Aug 16, 2022
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Aug 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
12eb516 
…k@main

PR link: networkservicemesh/sdk#1340

Commit: 67e508c
Author: Artem Glazychev
Date: 2022-08-16 18:06:30 +0700
Message:
  - Remove metadata from dnsContextClient (#1340)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Aug 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
65d748c 
…k@main

PR link: networkservicemesh/sdk#1340

Commit: 67e508c
Author: Artem Glazychev
Date: 2022-08-16 18:06:30 +0700
Message:
  - Remove metadata from dnsContextClient (#1340)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Aug 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
4026417 
…k@main

PR link: networkservicemesh/sdk#1340

Commit: 67e508c
Author: Artem Glazychev
Date: 2022-08-16 18:06:30 +0700
Message:
  - Remove metadata from dnsContextClient (#1340)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Aug 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c74b4d5 
…k@main

PR link: networkservicemesh/sdk#1340

Commit: 67e508c
Author: Artem Glazychev
Date: 2022-08-16 18:06:30 +0700
Message:
  - Remove metadata from dnsContextClient (#1340)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Aug 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d7707a3 
…k@main

PR link: networkservicemesh/sdk#1340

Commit: 67e508c
Author: Artem Glazychev
Date: 2022-08-16 18:06:30 +0700
Message:
  - Remove metadata from dnsContextClient (#1340)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Aug 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
bcefce1 
…k@main

PR link: networkservicemesh/sdk#1340

Commit: 67e508c
Author: Artem Glazychev
Date: 2022-08-16 18:06:30 +0700
Message:
  - Remove metadata from dnsContextClient (#1340)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Aug 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
23d16ec 
…k@main

PR link: networkservicemesh/sdk#1340

Commit: 67e508c
Author: Artem Glazychev
Date: 2022-08-16 18:06:30 +0700
Message:
  - Remove metadata from dnsContextClient (#1340)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Aug 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
345771b 
…k@main

PR link: networkservicemesh/sdk#1340

Commit: 67e508c
Author: Artem Glazychev
Date: 2022-08-16 18:06:30 +0700
Message:
  - Remove metadata from dnsContextClient (#1340)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Aug 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9676c77 
…k@main

PR link: networkservicemesh/sdk#1340

Commit: 67e508c
Author: Artem Glazychev
Date: 2022-08-16 18:06:30 +0700
Message:
  - Remove metadata from dnsContextClient (#1340)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Aug 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c262238 
…k@main

PR link: networkservicemesh/sdk#1340

Commit: 67e508c
Author: Artem Glazychev
Date: 2022-08-16 18:06:30 +0700
Message:
  - Remove metadata from dnsContextClient (#1340)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Aug 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c8ddf6b 
…k@main

PR link: networkservicemesh/sdk#1340

Commit: 67e508c
Author: Artem Glazychev
Date: 2022-08-16 18:06:30 +0700
Message:
  - Remove metadata from dnsContextClient (#1340)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Aug 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f7e9a16 
…k@main

PR link: networkservicemesh/sdk#1340

Commit: 67e508c
Author: Artem Glazychev
Date: 2022-08-16 18:06:30 +0700
Message:
  - Remove metadata from dnsContextClient (#1340)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Aug 16, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
49ad935 
…k@main

PR link: networkservicemesh/sdk#1340

Commit: 67e508c
Author: Artem Glazychev
Date: 2022-08-16 18:06:30 +0700
Message:
  - Remove metadata from dnsContextClient (#1340)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Aug 16, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@NikitaSkrynnik NikitaSkrynnik Awaiting requested review from NikitaSkrynnik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glazychev-art @denis-tingaikin