Add OPA to registry-memory server #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
pkg/registry/chains/memory/server.go
Outdated
| // NewServer creates new registry server based on memory storage | ||
| func NewServer(ctx context.Context, expiryDuration time.Duration, proxyRegistryURL *url.URL, dialOptions ...grpc.DialOption) registryserver.Registry { | ||
| func NewServer(ctx context.Context, expiryDuration time.Duration, proxyRegistryURL *url.URL, options ...Option) registryserver.Registry { |
There was a problem hiding this comment.
Here we can also convert expireDuration, and proxyRegistryURL to otpion.
Default values:
expireDuration: time.Minute
proxyRegistryURL: nil
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
denis-tingaikin
approved these changes
Sep 15, 2022
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Sep 15, 2022
…k@main PR link: networkservicemesh/sdk#1352 Commit: b47cbd4 Author: Nikita Skrynnik Date: 2022-09-16 01:57:34 +0700 Message: - Add OPA to registry-memory server (#1352) * add options for registry-memory server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more options to registry memory server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Sep 15, 2022
…k@main PR link: networkservicemesh/sdk#1352 Commit: b47cbd4 Author: Nikita Skrynnik Date: 2022-09-16 01:57:34 +0700 Message: - Add OPA to registry-memory server (#1352) * add options for registry-memory server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more options to registry memory server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Sep 15, 2022
…k@main PR link: networkservicemesh/sdk#1352 Commit: b47cbd4 Author: Nikita Skrynnik Date: 2022-09-16 01:57:34 +0700 Message: - Add OPA to registry-memory server (#1352) * add options for registry-memory server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more options to registry memory server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Sep 15, 2022
…k@main PR link: networkservicemesh/sdk#1352 Commit: b47cbd4 Author: Nikita Skrynnik Date: 2022-09-16 01:57:34 +0700 Message: - Add OPA to registry-memory server (#1352) * add options for registry-memory server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more options to registry memory server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Sep 15, 2022
…k@main PR link: networkservicemesh/sdk#1352 Commit: b47cbd4 Author: Nikita Skrynnik Date: 2022-09-16 01:57:34 +0700 Message: - Add OPA to registry-memory server (#1352) * add options for registry-memory server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more options to registry memory server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Sep 15, 2022
…k@main PR link: networkservicemesh/sdk#1352 Commit: b47cbd4 Author: Nikita Skrynnik Date: 2022-09-16 01:57:34 +0700 Message: - Add OPA to registry-memory server (#1352) * add options for registry-memory server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more options to registry memory server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Sep 15, 2022
…k@main PR link: networkservicemesh/sdk#1352 Commit: b47cbd4 Author: Nikita Skrynnik Date: 2022-09-16 01:57:34 +0700 Message: - Add OPA to registry-memory server (#1352) * add options for registry-memory server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more options to registry memory server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Sep 15, 2022
…k@main PR link: networkservicemesh/sdk#1352 Commit: b47cbd4 Author: Nikita Skrynnik Date: 2022-09-16 01:57:34 +0700 Message: - Add OPA to registry-memory server (#1352) * add options for registry-memory server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more options to registry memory server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Sep 15, 2022
…k@main PR link: networkservicemesh/sdk#1352 Commit: b47cbd4 Author: Nikita Skrynnik Date: 2022-09-16 01:57:34 +0700 Message: - Add OPA to registry-memory server (#1352) * add options for registry-memory server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more options to registry memory server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Sep 15, 2022
…k@main PR link: networkservicemesh/sdk#1352 Commit: b47cbd4 Author: Nikita Skrynnik Date: 2022-09-16 01:57:34 +0700 Message: - Add OPA to registry-memory server (#1352) * add options for registry-memory server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more options to registry memory server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Sep 15, 2022
…k@main PR link: networkservicemesh/sdk#1352 Commit: b47cbd4 Author: Nikita Skrynnik Date: 2022-09-16 01:57:34 +0700 Message: - Add OPA to registry-memory server (#1352) * add options for registry-memory server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more options to registry memory server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nikita Skrynnik nikita.skrynnik@xored.com
Description
Issue link
How Has This Been Tested?
Types of changes